| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The completion function itself now parses --list-options on the first
tab press and caches the results. This does mean a slight delay on that
first tab press, but it will only do this if the argument being
completed looks like an option (i.e. starts with "-"), so there is never
a delay when just completing a file name. I've also put some effort into
making it reasonably fast; on my machine it's consistently under 100 ms,
more than half of which is mpv itself.
Installation of zsh completion is now done unconditionally because it's
nothing more than copying a file. If you really don't want it installed,
set zshdir to empty: `./waf configure --zshdir= ...`
Improvements in functionality compared to the old script:
* Produces the right results for mpv binaries other than the one it was
installed with (like a dev build for testing changes).
* Does not require running mpv at build time, so it won't cause
problems with cross compilation.
* Handles aliases.
* Slightly nicer handling of options that take comma-separated values
and/or sub-options: A space is now inserted at the end instead of a
comma, allowing you to immediately start typing the next argument,
but typing a comma will still remove the automatically added space,
and = and : will now do that too, so you can immediately add a
sub-option.
* More general/flexible handling of values for options that print their
possible values with --option=help. The code as is could handle quite
a few more options (*scale, demuxers, decoders, ...), but nobody
wants to maintain that list here so we'll just stick with what the
old completion script already did.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
--vf=help will now list libavfilter filters, and e.g. --vf=yadif=help
will list libavfilter filter options.
The latter is rather bare, because the AVOption API is really awful
(holy shit how is it so bad), and would require us to handle _every_
option type manually.
Alternatively we could call av_opt_show2(), which ffmpeg uses for help
output in its CLI tools and which is much more detailed. But it's rather
foreign and forces output through av_log(), so I don't really want to
use it.
|
| |
|
|
|
| |
wscript calls them directly, and thus are probably part of the build
system. They seem to be fully covered by relicensing agreements.
|
| | |
|
| |
|
|
|
|
|
| |
Closes #2273. See that issue for explanation/discussion.
I'll add examples on how to filter in your own config to the wiki soon:
https://github.com/mpv-player/mpv/wiki/Zsh-completion-customization
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will catch cases where mpv runs without error, but the
--list-options output isn't what we expect. Otherwise, we'll make a
broken completion file that will result in cryptic errors when pressing
tab, like:
_mpv:18: command not found: *:files:->mfiles
That's been the case for most of the zsh completion issues we've had
reported, that I can remember.
Also make uninitialized variable access fatal so that failures to parse
other options will also make the script die eventually, albeit with a
less nice message.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
| |
I'm an idiot.
Fixes #3032.
|
| |
|
|
|
|
|
| |
...unless no files match. Fixes #2892.
To get the old behaviour back, use something like:
zstyle ':completion:*:*:mpv:*' tag-order
|
| | |
|
| | |
|
| |
|
|
|
| |
Ignore the other bits of $?. Apparently they can be set even if the
command succeeded.
|
| | |
|
| |
|
|
| |
It still doesn't deal with sub-options, but that's for another day.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
No more equals signs for options that don't take values.
Complete values for options with preset choices.
Complete --no-whatever where applicable.
Fixes #997.
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
Implemented in shell, because it has to be done at runtime.
|
| |
|
|
|
|
| |
The previous commit made the completion script always return non-zero, even when
a match is found. This explicitly sets the return value to zero whenever a match
is found but defaults to non-zero in case nothing is matched.
|
| |
|
|
|
|
|
|
| |
Returning a non-zero value signals to the zsh completion system that no matches
were added by the script so that it can try the user-defined matchers (e.g.
those defined with matcher-list).
Fixes #1008.
|
| | |
|
| |
|
|
|
| |
This stops options that are prefixes of other options from blocking
completion of values for the longer ones.
|
| | |
|
| |
|
|
|
|
|
|
|
| |
Don't use _x_arguments, as we don't support X arguments.
Get rid of -s, because we don't support multiple single-letter options
in one argument.
Add -S, because we ignore options after "--".
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Completion now uses "--opt=value" instead of "--opt value". Once the
user presses space and starts a new argument, the option just
completed is out of the picture, whether or not it was given an
argument. This handles options with no arguments or optional arguments
much better; previously, completing such an option would effectively
disable completion for the next argument.
Custom completed options such as "--ao" and friends will no longer
claim to consume an extra argument.
|
| | |
|
|
|
As discussed in #775
|
