path: root/audio
diff options
authorwm4 <wm4@nowhere>2016-09-01 14:21:32 +0200
committerwm4 <wm4@nowhere>2016-09-01 14:21:32 +0200
commit6b4f560f3ccca0f7db345bd7a6ed65e9307b432d (patch)
tree831199a941a1bf34959ca3809460655eb05f7685 /audio
parentec3c428e5fb03244b9f8f4f7432779b45a181166 (diff)
vo, ao: disable positional parameter suboptions
Positional parameters cause problems because they can be ambiguous with flag options. If a flag option is removed or turned into a non-flag option, it'll usually be interpreted as value for the first sub-option (as positional parameter), resulting in very confusing error messages. This changes it into a simple "option not found" error. I don't expect that anyone really used positional parameters with --vo or --ao. Although the docs for --ao=pulse seem to encourage positional parameters for the host/sink options, which means it could possibly annoy some PulseAudio users. --vf and --af are still mostly used with positional parameters, so this must be a configurable option in the option parser.
Diffstat (limited to 'audio')
1 files changed, 1 insertions, 0 deletions
diff --git a/audio/out/ao.c b/audio/out/ao.c
index cf66e0c64b..fcbc44b139 100644
--- a/audio/out/ao.c
+++ b/audio/out/ao.c
@@ -121,6 +121,7 @@ const struct m_obj_list ao_obj_list = {
.description = "audio outputs",
.allow_unknown_entries = true,
.allow_trailer = true,
+ .disallow_positional_parameters = true,
static struct ao *ao_alloc(bool probing, struct mpv_global *global,