From 6b4f560f3ccca0f7db345bd7a6ed65e9307b432d Mon Sep 17 00:00:00 2001 From: wm4 Date: Thu, 1 Sep 2016 14:21:32 +0200 Subject: vo, ao: disable positional parameter suboptions Positional parameters cause problems because they can be ambiguous with flag options. If a flag option is removed or turned into a non-flag option, it'll usually be interpreted as value for the first sub-option (as positional parameter), resulting in very confusing error messages. This changes it into a simple "option not found" error. I don't expect that anyone really used positional parameters with --vo or --ao. Although the docs for --ao=pulse seem to encourage positional parameters for the host/sink options, which means it could possibly annoy some PulseAudio users. --vf and --af are still mostly used with positional parameters, so this must be a configurable option in the option parser. --- audio/out/ao.c | 1 + 1 file changed, 1 insertion(+) (limited to 'audio') diff --git a/audio/out/ao.c b/audio/out/ao.c index cf66e0c64b..fcbc44b139 100644 --- a/audio/out/ao.c +++ b/audio/out/ao.c @@ -121,6 +121,7 @@ const struct m_obj_list ao_obj_list = { .description = "audio outputs", .allow_unknown_entries = true, .allow_trailer = true, + .disallow_positional_parameters = true, }; static struct ao *ao_alloc(bool probing, struct mpv_global *global, -- cgit v1.2.3