vo_sixel: Implement write() loop

Not all systems are Linux. Also update the comment to better reflect
POSIX documentation.

1 files changed, 16 insertions, 4 deletions

diff --git a/video/out/vo_sixel.c b/video/out/vo_sixel.c
index 6c4b0d7466..77eeb571e6 100644
--- a/video/out/vo_sixel.c
+++ b/video/out/vo_sixel.c
@@ -336,11 +336,23 @@ static inline int sixel_write(char *data, int size, void *priv)
 {
     FILE *p = (FILE *)priv;
     // On POSIX platforms, write() is the fastest method. It also is the only
-    // one that—if implemented correctly—ensures atomic writes so mpv’s
-    // output will not be interrupted by other processes or threads that write
-    // to stdout, which would cause screen corruption.
+    // one that allows atomic writes so mpv’s output will not be interrupted
+    // by other processes or threads that write to stdout, which would cause
+    // screen corruption. POSIX does not guarantee atomicity for writes
+    // exceeding PIPE_BUF, but at least Linux does seem to implement it that
+    // way.
 #if HAVE_POSIX
-    return write(fileno(p), data, size);
+    int remain = size;
+
+    while (remain > 0) {
+        ssize_t written = write(fileno(p), data, remain);
+        if (written < 0)
+            return written;
+        remain -= written;
+        data += written;
+    }
+
+    return size;
 #else
     int ret = fwrite(data, 1, size, p);
     fflush(p);