summaryrefslogtreecommitdiffstats
path: root/video/out/vo.c
diff options
context:
space:
mode:
authorDudemanguy <random342@airmail.cc>2020-08-16 19:14:54 -0500
committerJan Ekström <jeebjp@gmail.com>2020-08-17 19:36:04 +0300
commit0216f8c787cb8a2526e0fe8207d7d12c5aeff327 (patch)
treee4e02b9bcb22ad7a9334f5abc9fcaba2a494008d /video/out/vo.c
parent486516f723d3159c82c75b15a2eefed366542b77 (diff)
downloadmpv-0216f8c787cb8a2526e0fe8207d7d12c5aeff327.tar.bz2
mpv-0216f8c787cb8a2526e0fe8207d7d12c5aeff327.tar.xz
wayland: soften GNOME warning
We've had some serious issues with GNOME in the past, but since then their compositor has undergone some major internal improvements. The most severe one [1], random vsync spikes and mistimed frames, can no longer be reproduced by the original author of the issue. There are some minor UI-related things (lack of window decorations for instance since there is no xdg-decoration support), but users don't seem to complain about that too much and they aren't revelant to playback. 3.38 isn't out quite yet, but that should also fix playback issues when on a multimonitor setup (the fix is in the master branch at the moment). In terms of playback, the only real concerning issue is the lack of idle inhibit so a warning is still displayed. But GNOME has their own workaround that users can use for that so if anyone happens to complain, we can just point them to that. [1] https://gitlab.gnome.org/GNOME/mutter/-/issues/957
Diffstat (limited to 'video/out/vo.c')
-rw-r--r--video/out/vo.c7
1 files changed, 0 insertions, 7 deletions
diff --git a/video/out/vo.c b/video/out/vo.c
index 1535994a69..27be4735ab 100644
--- a/video/out/vo.c
+++ b/video/out/vo.c
@@ -340,13 +340,6 @@ error:
struct vo *init_best_video_out(struct mpv_global *global, struct vo_extra *ex)
{
- const char *xdg_current_desktop = getenv("XDG_CURRENT_DESKTOP");
- if (xdg_current_desktop && strstr(xdg_current_desktop, "GNOME")) {
- struct mp_log *log = mp_log_new(NULL, global->log, "vo");
- mp_fatal(log, "GNOME detected. Things will be broken.\n");
- talloc_free(log);
- }
-
struct mp_vo_opts *opts = mp_get_config_group(NULL, global, &vo_sub_opts);
struct m_obj_settings *vo_list = opts->video_driver_list;
struct vo *vo = NULL;