summaryrefslogtreecommitdiffstats
path: root/video/out/gpu/video.h
diff options
context:
space:
mode:
authorPhilip Langdale <philipl@overt.org>2022-02-06 14:18:59 -0800
committerPhilip Langdale <github.philipl@overt.org>2022-02-17 20:02:32 -0800
commit5186651f304fb49867f2542d2eb149f8191cf0de (patch)
treec04acfdbf374bb4142c0c564a73aecd98082c977 /video/out/gpu/video.h
parentbc9805c71a67b2717c79533731608eff679cded1 (diff)
downloadmpv-5186651f304fb49867f2542d2eb149f8191cf0de.tar.bz2
mpv-5186651f304fb49867f2542d2eb149f8191cf0de.tar.xz
vo_gpu: hwdec: load hwdec interops on-demand by default
Historically, we have treated hwdec interop loading as a completely separate step from loading the hwdecs themselves. Some hwdecs need an interop, and some don't, and users generally configure the exact hwdec they want, so interops that aren't relevant for that hwdec shouldn't be loaded to save time and avoid warning/error spam. The basic approach here is to recognise that interops are tied to hwdecs by imgfmt. The hwdec outputs some format, and an interop is needed to get that format to the vo without read back. So, when we try to load an hwdec, instead of just blindly loading all interops as we do today, let's pass the imgfmt in and only load interops that work for that format. If more than one interop is available for the format, the existing logic (whatever it is) will continue to be used to pick one. We also have one callsite in filters where we seem to pre-emptively load all the interops. It's probably possible to trace down a specific format but for now I'm just letting it keep loading all of them; it's no worse than before. You may notice there is no documentation update - and that's because the current docs say that when the interop mode is `auto`, the interop is loaded on demand. So reality now reflects the docs. How nice.
Diffstat (limited to 'video/out/gpu/video.h')
-rw-r--r--video/out/gpu/video.h3
1 files changed, 2 insertions, 1 deletions
diff --git a/video/out/gpu/video.h b/video/out/gpu/video.h
index 0bb180e514..4c6422b1ab 100644
--- a/video/out/gpu/video.h
+++ b/video/out/gpu/video.h
@@ -220,7 +220,8 @@ bool gl_video_showing_interpolated_frame(struct gl_video *p);
struct mp_hwdec_devices;
void gl_video_load_hwdecs(struct gl_video *p, struct mp_hwdec_devices *devs,
bool load_all_by_default);
-void gl_video_load_hwdecs_all(struct gl_video *p, struct mp_hwdec_devices *devs);
+void gl_video_load_hwdecs_for_img_fmt(struct gl_video *p, struct mp_hwdec_devices *devs,
+ int imgfmt);
struct vo;
void gl_video_configure_queue(struct gl_video *p, struct vo *vo);