summaryrefslogtreecommitdiffstats
path: root/video/out/gpu/video.c
diff options
context:
space:
mode:
authorNiklas Haas <git@haasn.dev>2023-07-18 15:35:13 +0200
committerNiklas Haas <github-daiK1o@haasn.dev>2023-09-01 21:02:19 +0200
commitb4c98cb04c87999eccd061cc59e6f5f8fa706220 (patch)
treee4b5f79aa7f341b6292286695abce76c43e1c7e1 /video/out/gpu/video.c
parenteca51d8e4593685638cd3384452cedfd1c1448c2 (diff)
downloadmpv-b4c98cb04c87999eccd061cc59e6f5f8fa706220.tar.bz2
mpv-b4c98cb04c87999eccd061cc59e6f5f8fa706220.tar.xz
vo_gpu: remove --tone-mapping-mode
`--vo=gpu-next` no longer uses this option, being replaced entirely by a luminance-based approach internally. And even for `--vo=gpu`, the values other than 'hybrid' are universally inferior in quality. In the interest of gradually reducing the amount of option bloat here, remove this mostly-pointless option.
Diffstat (limited to 'video/out/gpu/video.c')
-rw-r--r--video/out/gpu/video.c19
1 files changed, 1 insertions, 18 deletions
diff --git a/video/out/gpu/video.c b/video/out/gpu/video.c
index a03e6e80c4..97778c1f46 100644
--- a/video/out/gpu/video.c
+++ b/video/out/gpu/video.c
@@ -394,12 +394,6 @@ const struct m_sub_options gl_video_conf = {
{"inverse-tone-mapping", OPT_BOOL(tone_map.inverse)},
{"tone-mapping-max-boost", OPT_FLOAT(tone_map.max_boost),
M_RANGE(1.0, 10.0)},
- {"tone-mapping-mode", OPT_CHOICE(tone_map.mode,
- {"auto", TONE_MAP_MODE_AUTO},
- {"rgb", TONE_MAP_MODE_RGB},
- {"max", TONE_MAP_MODE_MAX},
- {"hybrid", TONE_MAP_MODE_HYBRID},
- {"luma", TONE_MAP_MODE_LUMA})},
{"tone-mapping-visualize", OPT_BOOL(tone_map.visualize)},
{"gamut-mapping-mode", OPT_CHOICE(tone_map.gamut_mode,
{"auto", GAMUT_AUTO},
@@ -499,6 +493,7 @@ const struct m_sub_options gl_video_conf = {
{"tone-mapping-desaturate", OPT_REMOVED("Replaced by --tone-mapping-mode")},
{"tone-mapping-desaturate-exponent", OPT_REMOVED("Replaced by --tone-mapping-mode")},
{"tone-mapping-crosstalk", OPT_REMOVED("Hard-coded as 0.04")},
+ {"tone-mapping-mode", OPT_REMOVED("no replacement")},
{0}
},
.size = sizeof(struct gl_video_opts),
@@ -2676,18 +2671,6 @@ static void pass_colormanage(struct gl_video *p, struct mp_colorspace src,
break;
}
- switch (p->opts.tone_map.mode) {
- case TONE_MAP_MODE_AUTO:
- case TONE_MAP_MODE_RGB:
- case TONE_MAP_MODE_MAX:
- case TONE_MAP_MODE_HYBRID:
- break;
- default:
- MP_WARN(p, "Tone mapping mode unsupported by vo_gpu, falling back.\n");
- p->opts.tone_map.mode = TONE_MAP_MODE_AUTO;
- break;
- }
-
switch (p->opts.tone_map.gamut_mode) {
case GAMUT_AUTO:
case GAMUT_WARN: