input: require VOs to send key up events, redo input key lookup

Making key up events implicit was sort-of a nice idea, but it's too
tricky and unreliable and makes the key lookup code (interpret_keys())
hard to reason about. See e.g. previous commit for subtle bugs and
issues this caused.

Make key-up events explicit instead. Add key up events to all VOs.
Any time MP_KEY_STATE_DOWN is used, the matching key up event must
use MP_KEY_STATE_UP.

Rewrite the key lookup code. It should be simpler and more robust now.
(Even though the LOC increases, because the new code is less "compact".)

1 files changed, 2 insertions, 2 deletions

diff --git a/video/out/cocoa_common.m b/video/out/cocoa_common.m
index 84d8e29b86..dd166e03e1 100644
--- a/video/out/cocoa_common.m
+++ b/video/out/cocoa_common.m
@@ -893,14 +893,14 @@ int vo_cocoa_cgl_color_size(struct vo *vo)
                 // doing the second click in a double click. Put in the key_fifo
                 // the key that would be put from the MouseUp handling code.
                 if([theEvent clickCount] == 2) {
-                    cocoa_put_key(MP_MOUSE_BTN0 + buttonNumber);
+                    cocoa_put_key((MP_MOUSE_BTN0 + buttonNumber) | MP_KEY_STATE_UP);
                     self.mouseDown = NO;
                 }
                 break;
             case NSLeftMouseUp:
             case NSRightMouseUp:
             case NSOtherMouseUp:
-                cocoa_put_key(MP_MOUSE_BTN0 + buttonNumber);
+                cocoa_put_key((MP_MOUSE_BTN0 + buttonNumber) | MP_KEY_STATE_UP);
                 self.mouseDown = NO;
                 break;
         }