diff options
| author | wm4 <wm4@nowhere> | 2016-08-30 23:52:16 +0200 |
|---|---|---|
| committer | wm4 <wm4@nowhere> | 2016-08-30 23:52:16 +0200 |
| commit | 4d755143216e4d8dec22b4918c1dd290a5efe814 (patch) | |
| tree | 177ef8dba13d14853fb79175d9dc8370d4823fbd /video/out/cocoa_common.m | |
| parent | af1379c43d6a5274b75bce0adeef9e3a9ce87bdf (diff) | |
| download | mpv-4d755143216e4d8dec22b4918c1dd290a5efe814.tar.bz2 mpv-4d755143216e4d8dec22b4918c1dd290a5efe814.tar.xz | |
vo: change messy handling of fullscreen and other flags
Before this commit, all VOs had to toggle the option flag themselves,
now command.c does it.
I can't really comprehend why it required every VO to do this manually.
Maybe it was for rejecting the property/option change if the VO didn't
support a specific capability. But then it could have checked the VOCTRL
result. In any case, I don't care, and successfully changing the
property without doing anything (With some VOs) is fine too. Many things
work this way now, and it's simpler overall.
This change will be useful for cleaning up VO option handling.
Diffstat (limited to 'video/out/cocoa_common.m')
| -rw-r--r-- | video/out/cocoa_common.m | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/video/out/cocoa_common.m b/video/out/cocoa_common.m index 557e28e4f1..7cb30cc49d 100644 --- a/video/out/cocoa_common.m +++ b/video/out/cocoa_common.m @@ -449,7 +449,6 @@ static int vo_cocoa_ontop(struct vo *vo) return VO_NOTIMPL; struct mp_vo_opts *opts = vo->opts; - opts->ontop = !opts->ontop; vo_set_level(vo, opts->ontop); return VO_TRUE; } @@ -793,7 +792,6 @@ static int vo_cocoa_control_on_main_thread(struct vo *vo, int request, void *arg switch (request) { case VOCTRL_FULLSCREEN: - opts->fullscreen = !opts->fullscreen; return vo_cocoa_fullscreen(vo); case VOCTRL_ONTOP: return vo_cocoa_ontop(vo); |