diff options
| author | wm4 <wm4@nowhere> | 2012-12-19 12:04:38 +0100 |
|---|---|---|
| committer | wm4 <wm4@nowhere> | 2013-01-13 20:04:11 +0100 |
| commit | aa6ba6372c627bc602647d225bdfb076f93bd291 (patch) | |
| tree | dd9a9840b123af5f48881d4d52b1697671018c02 /video/filter/vf_dlopen.c | |
| parent | ab94c64ed2d8b90bd7b0c348e79c2d8b8d055ee6 (diff) | |
| download | mpv-aa6ba6372c627bc602647d225bdfb076f93bd291.tar.bz2 mpv-aa6ba6372c627bc602647d225bdfb076f93bd291.tar.xz | |
mp_image: change how palette is handled
According to DOCS/OUTDATED-tech/colorspaces.txt, the following formats
are supposed to be palettized:
IMGFMT_BGR8
IMGFMT_RGB8,
IMGFMT_BGR4_CHAR
IMGFMT_RGB4_CHAR
IMGFMT_BGR4
IMGFMT_RGB4
Of these, only BGR8 and RGB8 are actually treated as palettized in some
way. ffmpeg has only one palettized format (AV_PIX_FMT_PAL8), and
IMGFMT_BGR8 was inconsistently mapped to packed non-palettized RGB
formats too (AV_PIX_FMT_BGR8). Moreover, vf_scale.c contained messy
hacks to generate a palette when AV_PIX_FMT_BGR8 is output. (libswscale
does not support AV_PIX_FMT_PAL8 output in the first place.)
Get rid of all of this, and introduce IMGFMT_PAL8, which directly maps
to AV_PIX_FMT_PAL8. Remove the palette creation code from vf_scale.c.
IMGFMT_BGR8 maps to AV_PIX_FMT_RGB8 (don't ask me why it's swapped),
without any palette use. Enabling it in vo_x11 or using it as vf_scale
input seems to give correct results.
Diffstat (limited to 'video/filter/vf_dlopen.c')
| -rw-r--r-- | video/filter/vf_dlopen.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/video/filter/vf_dlopen.c b/video/filter/vf_dlopen.c index 323f5231ee..81d924ca40 100644 --- a/video/filter/vf_dlopen.c +++ b/video/filter/vf_dlopen.c @@ -240,7 +240,7 @@ static int query_format(struct vf_instance *vf, unsigned int fmt) { if (IMGFMT_IS_HWACCEL(fmt)) return 0; // these can't really be filtered - if (fmt == IMGFMT_RGB8 || fmt == IMGFMT_BGR8) + if (fmt == IMGFMT_PAL8) return 0; // we don't have palette support, sorry const char *fmtname = mp_imgfmt_to_name(fmt); if (!fmtname) |