test: make tests part of the mpv binary

Until now, each .c file in test/ was built as separate, self-contained
binary. Each binary could be run to execute the tests it contained.

Change this and make them part of the normal mpv binary. Now the tests
have to be invoked via the --unittest option. Do this for two reasons:

- Tests now run within a "properly" initialized mpv instance, so all
  services are available.
- Possibly simplifying the situation for future build systems.

The first point is the main motivation. The mpv code is entangled with
mp_log and the option system. It feels like a bad idea to duplicate some
of the initialization of this just so you can call code using them.

I'm also getting rid of cmocka. There wouldn't be any problem to keep it
(it's a perfectly sane set of helpers), but NIH calls. I would have had
to aggregate all tests into a CMUnitTest list, and I don't see how I'd
get different types of entry points easily. Probably easily solvable,
but since we made only pretty basic use of this library, NIH-ing this is
actually easier (I needed a list of tests with custom metadata anyway,
so all what was left was reimplement the assert_* helpers).

Unit tests now don't output anything, and if they fail, they'll simply
crash and leave a message that typically requires inspecting the test
code to figure out what went wrong (and probably editing the test code
to get more information). I even merged the various test functions into
single ones. Sucks, but here you go.

chmap_sel.c is merged into chmap.c, because I didn't see the point of
this being separate. json.c drops the print_message() to go along with
the new silent-by-default idea, also there's a memory leak fix unrelated
to the rest of this commit.

The new code is enabled with --enable-tests (--enable-test goes away).
Due to waf's option parser, --enable-test still works, because it's a
unique prefix to --enable-tests.

1 files changed, 0 insertions, 136 deletions

diff --git a/test/chmap_sel.c b/test/chmap_sel.c
deleted file mode 100644
index 38a5254073..0000000000
--- a/test/chmap_sel.c
+++ /dev/null
@@ -1,136 +0,0 @@
-#include "test_helpers.h"
-#include "audio/chmap_sel.h"
-
-#define LAYOUTS(...) (char*[]){__VA_ARGS__, NULL}
-
-static void test_sel(const char *input, const char *expected_selection,
-                          char **layouts)
-{
-    struct mp_chmap_sel s = {0};
-    struct mp_chmap input_map;
-    struct mp_chmap expected_map;
-
-    assert_true(mp_chmap_from_str(&input_map, bstr0(input)));
-    assert_true(mp_chmap_from_str(&expected_map, bstr0(expected_selection)));
-
-    for (int n = 0; layouts[n]; n++) {
-        struct mp_chmap tmp;
-        assert_true(mp_chmap_from_str(&tmp, bstr0(layouts[n])));
-        int count = s.num_chmaps;
-        mp_chmap_sel_add_map(&s, &tmp);
-        assert_true(s.num_chmaps > count); // assure validity and max. count
-    }
-
-    assert_true(mp_chmap_sel_fallback(&s, &input_map));
-    // We convert expected_map to a chmap and then back to a string to avoid
-    // problems with ambiguous layouts.
-    assert_string_equal(mp_chmap_to_str(&input_map),
-                        mp_chmap_to_str(&expected_map));
-}
-
-static void test_mp_chmap_sel_fallback_upmix(void **state) {
-    test_sel("5.1", "7.1", LAYOUTS("7.1"));
-}
-
-static void test_mp_chmap_sel_fallback_downmix(void **state) {
-    test_sel("7.1", "5.1", LAYOUTS("5.1"));
-}
-
-static void test_mp_chmap_sel_fallback_incompatible(void **state) {
-    test_sel("7.1(wide-side)", "7.1", LAYOUTS("7.1"));
-}
-
-static void test_mp_chmap_sel_fallback_prefer_compatible(void **state) {
-    test_sel("7.1(wide-side)", "5.1(side)", LAYOUTS("7.1", "5.1(side)"));
-}
-
-static void test_mp_chmap_sel_fallback_prefer_closest_upmix(void **state) {
-    test_sel("3.1", "5.1", LAYOUTS("7.1", "5.1", "2.1", "stereo", "mono"));
-}
-
-static void test_mp_chmap_sel_fallback_use_replacements(void **state) {
-    test_sel("5.1", "7.1(rear)", LAYOUTS("7.1(rear)"));
-}
-
-static void test_mp_chmap_sel_fallback_inexact_equivalent(void **state) {
-    test_sel("5.1(side)", "5.1", LAYOUTS("5.1", "7.1"));
-}
-
-static void test_mp_chmap_sel_fallback_works_on_alsa_chmaps(void **state) {
-    test_sel("5.1", "7.1(alsa)", LAYOUTS("7.1(alsa)"));
-}
-
-static void test_mp_chmap_sel_fallback_mono_to_stereo(void **state) {
-    test_sel("mono", "stereo", LAYOUTS("stereo", "5.1"));
-}
-
-static void test_mp_chmap_sel_fallback_stereo_to_stereo(void **state) {
-    test_sel("stereo", "stereo", LAYOUTS("stereo", "5.1"));
-}
-
-static void test_mp_chmap_sel_fallback_no_downmix(void **state) {
-    test_sel("5.1(side)", "7.1(rear)", LAYOUTS("stereo", "7.1(rear)"));
-}
-
-static void test_mp_chmap_sel_fallback_minimal_downmix(void **state) {
-    test_sel("7.1", "fl-fr-lfe-fc-bl-br-flc-frc",
-             LAYOUTS("fl-fr-lfe-fc-bl-br-flc-frc", "3.0(back)"));
-}
-
-static void test_mp_chmap_sel_fallback_reject_unknown(void **state) {
-    struct mp_chmap a;
-    struct mp_chmap b;
-    struct mp_chmap_sel s = {0};
-
-    mp_chmap_set_unknown(&a, 2);
-
-    mp_chmap_from_str(&b, bstr0("5.1"));
-
-    mp_chmap_sel_add_map(&s, &a);
-    assert_false(mp_chmap_sel_fallback(&s, &b));
-    assert_string_equal(mp_chmap_to_str(&b), "5.1");
-}
-
-static void test_mp_chmap_sel_fallback_more_replacements(void **state) {
-    test_sel("quad", "quad(side)", LAYOUTS("quad(side)", "stereo"));
-    test_sel("quad", "quad(side)", LAYOUTS("quad(side)", "7.0"));
-    test_sel("quad", "quad(side)", LAYOUTS("7.0", "quad(side)"));
-    test_sel("quad", "7.1(wide-side)", LAYOUTS("7.1(wide-side)", "stereo"));
-    test_sel("quad", "7.1(wide-side)", LAYOUTS("stereo", "7.1(wide-side)"));
-    test_sel("quad", "fl-fr-sl-sr",
-             LAYOUTS("fl-fr-fc-bl-br", "fl-fr-sl-sr"));
-    test_sel("quad", "fl-fr-bl-br-na-na-na-na",
-             LAYOUTS("fl-fr-bl-br-na-na-na-na", "quad(side)", "stereo"));
-    test_sel("quad", "fl-fr-bl-br-na-na-na-na",
-             LAYOUTS("stereo", "quad(side)", "fl-fr-bl-br-na-na-na-na"));
-    test_sel("fl-fr-fc-lfe-sl-sr", "fl-fr-lfe-fc-bl-br-na-na",
-             LAYOUTS("fl-fr-lfe-fc-bl-br-na-na", "fl-fr-lfe-fc-bl-br-sdl-sdr"));
-    test_sel("fl-fr-fc-lfe-sl-sr", "fl-fr-lfe-fc-bl-br-na-na",
-             LAYOUTS("fl-fr-lfe-fc-bl-br-sdl-sdr", "fl-fr-lfe-fc-bl-br-na-na"));
-}
-
-static void test_mp_chmap_sel_fallback_na_channels(void **state) {
-    test_sel("na-fl-fr", "na-fl-fr", LAYOUTS("na-fl-fr-na", "fl-na-fr", "na-fl-fr",
-                                             "fl-fr-na-na", "na-na-fl-fr"));
-}
-
-int main(void) {
-    const struct CMUnitTest tests[] = {
-        cmocka_unit_test(test_mp_chmap_sel_fallback_upmix),
-        cmocka_unit_test(test_mp_chmap_sel_fallback_downmix),
-        cmocka_unit_test(test_mp_chmap_sel_fallback_incompatible),
-        cmocka_unit_test(test_mp_chmap_sel_fallback_prefer_compatible),
-        cmocka_unit_test(test_mp_chmap_sel_fallback_prefer_closest_upmix),
-        cmocka_unit_test(test_mp_chmap_sel_fallback_use_replacements),
-        cmocka_unit_test(test_mp_chmap_sel_fallback_inexact_equivalent),
-        cmocka_unit_test(test_mp_chmap_sel_fallback_works_on_alsa_chmaps),
-        cmocka_unit_test(test_mp_chmap_sel_fallback_mono_to_stereo),
-        cmocka_unit_test(test_mp_chmap_sel_fallback_stereo_to_stereo),
-        cmocka_unit_test(test_mp_chmap_sel_fallback_no_downmix),
-        cmocka_unit_test(test_mp_chmap_sel_fallback_minimal_downmix),
-        cmocka_unit_test(test_mp_chmap_sel_fallback_reject_unknown),
-        cmocka_unit_test(test_mp_chmap_sel_fallback_more_replacements),
-        cmocka_unit_test(test_mp_chmap_sel_fallback_na_channels),
-    };
-    return cmocka_run_group_tests(tests, NULL, NULL);
-}