path: add mp_find_config_file and reorganize some of the code

Add `mp_find_config_file` to search different known paths and use that in
ass_mp to look for the fontconfig configuration file.

Some incidental changes spawned by this feature where:

 * Buffer allocation for the strings containing the paths is now performed
   with talloc. All of the allocations are done on a NULL context, but it still
   improves readability of the code.
 * Move the OSX function for lookup inside of a bundle: this code path was
   currently not used by the bundle generated with `make osxbundle`. The plan
   is to use it again in a future commit to get a fontconfig config file.

1 files changed, 2 insertions, 2 deletions

diff --git a/sub/find_subfiles.c b/sub/find_subfiles.c
index 95004b564f..aa8df2ea49 100644
--- a/sub/find_subfiles.c
+++ b/sub/find_subfiles.c
@@ -212,10 +212,10 @@ char **find_text_subtitles(struct MPOpts *opts, const char *fname)
     }
 
     // Load subtitles in ~/.mplayer/sub limiting sub fuzziness
-    char *mp_subdir = get_path("sub/");
+    char *mp_subdir = mp_find_user_config_file("sub/");
     if (mp_subdir)
         append_dir_subtitles(opts, &slist, &n, bstr0(mp_subdir), fname, 1);
-    free(mp_subdir);
+    talloc_free(mp_subdir);
 
     // Sort subs by priority and append them
     qsort(slist, n, sizeof(*slist), compare_sub_priority);