lua: command_native_async: always callback a-sync

Previously if the raw command_native_async returned an error then the
callback function was run directly. This meant that script writers
potentially had to account for both synchronous and asynchronous logic
in the callback, which can happen even with seemingly 'safe' commands
if the mpv event queue is full.

This was at odds with the Javascript implementation of
the function, which always runs the callback asynchronously.

Now the mp.add_timeout function is used to run the callback
asynchronously on error, replicating the Javascript implementation.

This provides consistency for developers in how the callback is handled
in Lua, and increases consistency between the Lua and Javascript APIs.

1 files changed, 1 insertions, 1 deletions

diff --git a/player/lua/defaults.lua b/player/lua/defaults.lua
index 0643c0b1d9..dcbb4e0f62 100644
--- a/player/lua/defaults.lua
+++ b/player/lua/defaults.lua
@@ -617,7 +617,7 @@ function mp.command_native_async(node, cb)
     async_next_id = async_next_id + 1
     local res, err = mp.raw_command_native_async(id, node)
     if not res then
-        cb(false, nil, err)
+        mp.add_timeout(0, function() cb(false, nil, err) end)
         return res, err
     end
     local t = {cb = cb, id = id}