diff options
author | rathann <rathann@b3059339-0415-0410-9bf9-f77b7e298cf2> | 2006-02-09 14:08:03 +0000 |
---|---|---|
committer | rathann <rathann@b3059339-0415-0410-9bf9-f77b7e298cf2> | 2006-02-09 14:08:03 +0000 |
commit | e7db4ccf1afbb6653ae1aae44b1c96c724361985 (patch) | |
tree | 9cc7321a75460de67bd0dae4e940b73439a1374b /osdep/getch2.h | |
parent | 1f34ddefd2546a37c6efe4fcd9ea3f7627af4a5d (diff) | |
download | mpv-e7db4ccf1afbb6653ae1aae44b1c96c724361985.tar.bz2 mpv-e7db4ccf1afbb6653ae1aae44b1c96c724361985.tar.xz |
Patch by Stefan Huehner / stefan % huehner ! org \
patch replaces '()' for the correct '(void)' in function
declarations/prototypes which have no parameters. The '()' syntax tell
thats there is a variable list of arguments, so that the compiler cannot
check this. The extra CFLAG '-Wstrict-declarations' shows those cases.
Comments about a similar patch applied to ffmpeg:
That in C++ these mean the same, but in ANSI C the semantics are
different; function() is an (obsolete) K&R C style forward declaration,
it basically means that the function can have any number and any types
of parameters, effectively completely preventing the compiler from doing
any sort of type checking. -- Erik Slagter
Defining functions with unspecified arguments is allowed but bad.
With arguments unspecified the compiler can't report an error/warning
if the function is called with incorrect arguments. -- Måns Rullgård
git-svn-id: svn://svn.mplayerhq.hu/mplayer/trunk@17567 b3059339-0415-0410-9bf9-f77b7e298cf2
Diffstat (limited to 'osdep/getch2.h')
-rw-r--r-- | osdep/getch2.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/osdep/getch2.h b/osdep/getch2.h index 49743f2ecf..75bf463cc1 100644 --- a/osdep/getch2.h +++ b/osdep/getch2.h @@ -9,14 +9,14 @@ extern int screen_height; extern char * erase_to_end_of_line; /* Get screen-size using IOCTL call. */ -extern void get_screen_size(); +extern void get_screen_size(void); /* Load key definitions from the TERMCAP database. 'termtype' can be NULL */ extern int load_termcap(char *termtype); /* Enable and disable STDIN line-buffering */ -extern void getch2_enable(); -extern void getch2_disable(); +extern void getch2_enable(void); +extern void getch2_disable(void); /* Read a character or a special key code (see keycodes.h) */ extern int getch2(int halfdelay_time); |