From e7db4ccf1afbb6653ae1aae44b1c96c724361985 Mon Sep 17 00:00:00 2001 From: rathann Date: Thu, 9 Feb 2006 14:08:03 +0000 Subject: Patch by Stefan Huehner / stefan % huehner ! org \ MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit patch replaces '()' for the correct '(void)' in function declarations/prototypes which have no parameters. The '()' syntax tell thats there is a variable list of arguments, so that the compiler cannot check this. The extra CFLAG '-Wstrict-declarations' shows those cases. Comments about a similar patch applied to ffmpeg: That in C++ these mean the same, but in ANSI C the semantics are different; function() is an (obsolete) K&R C style forward declaration, it basically means that the function can have any number and any types of parameters, effectively completely preventing the compiler from doing any sort of type checking. -- Erik Slagter Defining functions with unspecified arguments is allowed but bad. With arguments unspecified the compiler can't report an error/warning if the function is called with incorrect arguments. -- Måns Rullgård git-svn-id: svn://svn.mplayerhq.hu/mplayer/trunk@17567 b3059339-0415-0410-9bf9-f77b7e298cf2 --- osdep/getch2.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'osdep/getch2.h') diff --git a/osdep/getch2.h b/osdep/getch2.h index 49743f2ecf..75bf463cc1 100644 --- a/osdep/getch2.h +++ b/osdep/getch2.h @@ -9,14 +9,14 @@ extern int screen_height; extern char * erase_to_end_of_line; /* Get screen-size using IOCTL call. */ -extern void get_screen_size(); +extern void get_screen_size(void); /* Load key definitions from the TERMCAP database. 'termtype' can be NULL */ extern int load_termcap(char *termtype); /* Enable and disable STDIN line-buffering */ -extern void getch2_enable(); -extern void getch2_disable(); +extern void getch2_enable(void); +extern void getch2_disable(void); /* Read a character or a special key code (see keycodes.h) */ extern int getch2(int halfdelay_time); -- cgit v1.2.3