diff options
| author | Dudemanguy <random342@airmail.cc> | 2023-08-06 21:39:17 -0500 |
|---|---|---|
| committer | Dudemanguy <random342@airmail.cc> | 2023-08-28 18:43:46 +0000 |
| commit | 53d032374d9f8fdfca260ed9a67190c37159f7c2 (patch) | |
| tree | 30465e4d30f25010ebe51432f86cce81c798de69 /options/options.c | |
| parent | e1f9444d4da5eacb30359ae210b1f1d3831ca05c (diff) | |
| download | mpv-53d032374d9f8fdfca260ed9a67190c37159f7c2.tar.bz2 mpv-53d032374d9f8fdfca260ed9a67190c37159f7c2.tar.xz | |
player: remove special auto option from alang/slang/vlang
This proved to be too problematic. Depending on the value of
--subs-with-matching-audio, you could either end up with cases where
--slang wasn't respected and users didn't get subtitles or alternatively
cases where subtitles were given and the user didn't ask for them.
Fundamentally, the OS language functionality doesn't really map well to
slang (and for alang/vlang it makes zero sense; not that anyone actually
used it). Instead of trying to shove it in an option where it doesn't
belong, we should split this off into something else. So for now, just
remove the special handling of "auto" and flip slang back to NULL.
Diffstat (limited to 'options/options.c')
| -rw-r--r-- | options/options.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/options/options.c b/options/options.c index 7b9156a823..13fefd5f0d 100644 --- a/options/options.c +++ b/options/options.c @@ -1042,9 +1042,6 @@ static const struct MPOpts mp_default_opts = { { [STREAM_AUDIO] = -2, [STREAM_VIDEO] = -2, [STREAM_SUB] = -2, }, }, - .stream_lang = { - [STREAM_SUB] = (char *[]){ "auto", NULL }, - }, .stream_auto_sel = true, .subs_with_matching_audio = true, .subs_fallback = 1, |