diff options
| author | Kacper Michajłow <kasper93@gmail.com> | 2024-02-26 04:55:00 +0100 |
|---|---|---|
| committer | Dudemanguy <random342@airmail.cc> | 2024-02-28 16:04:02 +0000 |
| commit | 0897604298120c3f197fa151ff85c9b5213c26f6 (patch) | |
| tree | 2c38308dce99430528ddf1c0746441ac8cdb7c42 /options/m_option.c | |
| parent | d955dfab294ecd24064f2d64b8af0bafc2af575c (diff) | |
| download | mpv-0897604298120c3f197fa151ff85c9b5213c26f6.tar.bz2 mpv-0897604298120c3f197fa151ff85c9b5213c26f6.tar.xz | |
various: avoid function pointer casts
The opt validator functions are casted to generic validator, which has
erased type for value. Calling function by pointer of different
definition is an UB.
Avoid that by generating wrapper function that does proper argument type
conversion and calls validator function. Type erased functions have
mangled type in the name.
Fixes UBSAN failures on Clang 17, which enabled fsanitize=function by
default.
Diffstat (limited to 'options/m_option.c')
| -rw-r--r-- | options/m_option.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/options/m_option.c b/options/m_option.c index 47f9c07883..02dea2bf3c 100644 --- a/options/m_option.c +++ b/options/m_option.c @@ -61,11 +61,6 @@ const char m_option_path_separator = OPTION_PATH_SEPARATOR; #define OPT_INT_MAX(opt, T, Tm) ((opt)->min < (opt)->max \ ? ((opt)->max >= (double)(Tm) ? (Tm) : (T)((opt)->max)) : (Tm)) -#if defined(__clang__) -// Last argument of validate functions is always a pointer, but not always void* -// which triggers UBSAN warning. -__attribute__((no_sanitize("function"))) -#endif int m_option_parse(struct mp_log *log, const m_option_t *opt, struct bstr name, struct bstr param, void *dst) { |