diff options
| author | wm4 <wm4@nowhere> | 2012-08-03 05:55:02 +0200 |
|---|---|---|
| committer | wm4 <wm4@nowhere> | 2012-08-03 05:55:02 +0200 |
| commit | b4d9647d189a6bb924fc6b415ae18969885f11f1 (patch) | |
| tree | f794e727435ef230f52dd1fac7c0f7029dc7b083 /libvo/video_out.h | |
| parent | 11648493db7db164aa8fe01751b7e5c5e5faa810 (diff) | |
| download | mpv-b4d9647d189a6bb924fc6b415ae18969885f11f1.tar.bz2 mpv-b4d9647d189a6bb924fc6b415ae18969885f11f1.tar.xz | |
mplayer: do not create X11 state in player frontend
This is about the vo_x11_init_state() call. It basically opens a X11
connection. It's called in the main() function once. It's not really
clear why this isn't done on VO creation instead. Maybe one reason was
that --no-fixed-vo used to be the default: when playing a new file, the
full VO state would be free'd and recreated. Keeping the X11 connection
possibly improved things, although the question is how. In summary,
there is no good reason to do this, and it only adds platform specific
details to the player frontend.
Do the X11 initialization in the respective VOs instead.
Diffstat (limited to 'libvo/video_out.h')
| -rw-r--r-- | libvo/video_out.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libvo/video_out.h b/libvo/video_out.h index 62bbf89975..203e6b47b7 100644 --- a/libvo/video_out.h +++ b/libvo/video_out.h @@ -297,7 +297,7 @@ struct vo { char *window_title; }; -struct vo *init_best_video_out(struct MPOpts *opts, struct vo_x11_state *x11, +struct vo *init_best_video_out(struct MPOpts *opts, struct mp_fifo *key_fifo, struct input_ctx *input_ctx); int vo_config(struct vo *vo, uint32_t width, uint32_t height, |