x = malloc(strlen(s) + c) ... strcpy(x, s)

replaced by
x = strdup(s)

Note: sometimes c was 0 and that was a bug
Note2: code still has to be added to check the returned value of these funcs


git-svn-id: svn://svn.mplayerhq.hu/mplayer/trunk@3613 b3059339-0415-0410-9bf9-f77b7e298cf2

1 files changed, 4 insertions, 8 deletions

diff --git a/libmpdemux/demux_viv.c b/libmpdemux/demux_viv.c
index 891925d9c6..a9611d2898 100644
--- a/libmpdemux/demux_viv.c
+++ b/libmpdemux/demux_viv.c
@@ -191,26 +191,22 @@ static void vivo_parse_text_header(demuxer_t *demux, int header_len)
 	if (!strcmp(opt, "Title"))
 	{
 	    demux_info_add(demux, "name", param);
-	    priv->title = malloc(strlen(param));
-	    strcpy(priv->title, param);
+	    priv->title = strdup(param);
 	}
 	if (!strcmp(opt, "Author"))
 	{
 	    demux_info_add(demux, "author", param);
-	    priv->author = malloc(strlen(param));
-	    strcpy(priv->author, param);
+	    priv->author = strdup(param);
 	}
 	if (!strcmp(opt, "Copyright"))
 	{
 	    demux_info_add(demux, "copyright", param);
-	    priv->copyright = malloc(strlen(param));
-	    strcpy(priv->copyright, param);
+	    priv->copyright = strdup(param);
 	}
 	if (!strcmp(opt, "Producer"))
 	{
 	    demux_info_add(demux, "encoder", param);
-	    priv->producer = malloc(strlen(param));
-	    strcpy(priv->producer, param);
+	    priv->producer = strdup(param);
 	}
 
 	/* get next token */