diff options
| author | reimar <reimar@b3059339-0415-0410-9bf9-f77b7e298cf2> | 2008-07-11 19:00:49 +0000 |
|---|---|---|
| committer | reimar <reimar@b3059339-0415-0410-9bf9-f77b7e298cf2> | 2008-07-11 19:00:49 +0000 |
| commit | ffc22175d30109188d9ab959a35d3a7a288146d2 (patch) | |
| tree | a26809b478328b2a6391560e8b0ab04487ba9487 /libmpcodecs | |
| parent | 68e6f22bbc24352e1eea71054f861b3209b52a9d (diff) | |
| download | mpv-ffc22175d30109188d9ab959a35d3a7a288146d2.tar.bz2 mpv-ffc22175d30109188d9ab959a35d3a7a288146d2.tar.xz | |
Add a comment on shift vs. division
git-svn-id: svn://svn.mplayerhq.hu/mplayer/trunk@27259 b3059339-0415-0410-9bf9-f77b7e298cf2
Diffstat (limited to 'libmpcodecs')
| -rw-r--r-- | libmpcodecs/ad_msadpcm.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/libmpcodecs/ad_msadpcm.c b/libmpcodecs/ad_msadpcm.c index 38d35884c8..7e5ea7b071 100644 --- a/libmpcodecs/ad_msadpcm.c +++ b/libmpcodecs/ad_msadpcm.c @@ -171,6 +171,9 @@ static int ms_adpcm_decode_block(unsigned short *output, unsigned char *input, upper_nibble ^= 1; SE_4BIT(snibble); + // should this really be a division and not a shift? + // coefficients were originally scaled by for, which might have + // been an optimization for 8-bit CPUs _if_ a shift is correct predictor = ( ((sample1[current_channel] * coeff1[current_channel]) + (sample2[current_channel] * coeff2[current_channel])) / 64) + |