ao_pulse: don't always print error message if PulseAudio unavailable

PulseAudio is rather high on the auto proving order (to avoid using an
emulated sound API), but it prints an annoying error message if the
PA client library can't connect to a server. On the other hand, we do
want this error message printed if the user explicitly selects the
pulse audio output driver.

Add a flag to indicate that an AO is opened due to auto probing.
ao_pulse checks that flag, and if it's set, do not print if the
initialization error is PA_ERR_CONNECTIONREFUSED, whcih I assume is
the error signalling PulseAudio unavailability. (This error happens
if no PulseAudio server is installed.)

1 files changed, 5 insertions, 2 deletions

diff --git a/libao2/ao_pulse.c b/libao2/ao_pulse.c
index e48c402fa6..062dde9ecf 100644
--- a/libao2/ao_pulse.c
+++ b/libao2/ao_pulse.c
@@ -297,8 +297,11 @@ unlock_and_fail:
         pa_threaded_mainloop_unlock(priv->mainloop);
 
 fail:
-    if (priv->context)
-        GENERIC_ERR_MSG(priv->context, "Init failed");
+    if (priv->context) {
+        if (!(pa_context_errno(priv->context) == PA_ERR_CONNECTIONREFUSED
+              && ao->probing))
+            GENERIC_ERR_MSG(priv->context, "Init failed");
+    }
     free(devarg);
     uninit(ao, true);
     return -1;