diff options
| author | rathann <rathann@b3059339-0415-0410-9bf9-f77b7e298cf2> | 2006-02-09 14:08:03 +0000 |
|---|---|---|
| committer | rathann <rathann@b3059339-0415-0410-9bf9-f77b7e298cf2> | 2006-02-09 14:08:03 +0000 |
| commit | e7db4ccf1afbb6653ae1aae44b1c96c724361985 (patch) | |
| tree | 9cc7321a75460de67bd0dae4e940b73439a1374b /libao2/ao_esd.c | |
| parent | 1f34ddefd2546a37c6efe4fcd9ea3f7627af4a5d (diff) | |
| download | mpv-e7db4ccf1afbb6653ae1aae44b1c96c724361985.tar.bz2 mpv-e7db4ccf1afbb6653ae1aae44b1c96c724361985.tar.xz | |
Patch by Stefan Huehner / stefan % huehner ! org \
patch replaces '()' for the correct '(void)' in function
declarations/prototypes which have no parameters. The '()' syntax tell
thats there is a variable list of arguments, so that the compiler cannot
check this. The extra CFLAG '-Wstrict-declarations' shows those cases.
Comments about a similar patch applied to ffmpeg:
That in C++ these mean the same, but in ANSI C the semantics are
different; function() is an (obsolete) K&R C style forward declaration,
it basically means that the function can have any number and any types
of parameters, effectively completely preventing the compiler from doing
any sort of type checking. -- Erik Slagter
Defining functions with unspecified arguments is allowed but bad.
With arguments unspecified the compiler can't report an error/warning
if the function is called with incorrect arguments. -- Måns Rullgård
git-svn-id: svn://svn.mplayerhq.hu/mplayer/trunk@17567 b3059339-0415-0410-9bf9-f77b7e298cf2
Diffstat (limited to 'libao2/ao_esd.c')
| -rw-r--r-- | libao2/ao_esd.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/libao2/ao_esd.c b/libao2/ao_esd.c index 2ce2efc7c5..297787f6c8 100644 --- a/libao2/ao_esd.c +++ b/libao2/ao_esd.c @@ -346,7 +346,7 @@ static int play(void* data, int len, int flags) /* * stop playing, keep buffers (for pause) */ -static void audio_pause() +static void audio_pause(void) { /* * not possible with esd. the esd daemom will continue playing @@ -358,7 +358,7 @@ static void audio_pause() /* * resume playing, after audio_pause() */ -static void audio_resume() +static void audio_resume(void) { /* * not possible with esd. @@ -375,7 +375,7 @@ static void audio_resume() /* * stop playing and empty buffers (for seeking/pause) */ -static void reset() +static void reset(void) { #ifdef __svr4__ /* throw away data buffered in the esd connection */ @@ -388,7 +388,7 @@ static void reset() /* * return: how many bytes can be played without blocking */ -static int get_space() +static int get_space(void) { struct timeval tmout; fd_set wfds; @@ -432,7 +432,7 @@ static int get_space() /* * return: delay in seconds between first and last sample in buffer */ -static float get_delay() +static float get_delay(void) { struct timeval now; double buffered_samples_time; |