diff options
author | iive <iive@b3059339-0415-0410-9bf9-f77b7e298cf2> | 2007-08-20 14:17:43 +0000 |
---|---|---|
committer | iive <iive@b3059339-0415-0410-9bf9-f77b7e298cf2> | 2007-08-20 14:17:43 +0000 |
commit | 78dbd8ba260260585650a4b7a748f0e600771b6d (patch) | |
tree | 41d89d25b4d2f84e26809c8c8f94fb0991e8ddd0 /gui/interface.h | |
parent | 80ef41dccfb69b2d55ced1ad2ae68b1ea9d1d3ff (diff) | |
download | mpv-78dbd8ba260260585650a4b7a748f0e600771b6d.tar.bz2 mpv-78dbd8ba260260585650a4b7a748f0e600771b6d.tar.xz |
remove gconvert_uri_to_filename() and use url_unescape_string() instead.
reasons:
* gconvert strdup()s the original string, but it may exit without returning or freeing it.
* gconvert returns the original pointer when no % escaping is done. It is then free()ed and used in that state.
* gconvert doesn't consider that % may be at the end of the string and could continue parsing past the end.
* gconvert would try to free() pointer that iconv() have modified.
* gconvert would try to convert filenames from utf-8 to iso8859-1.
Seems like no other DnD programs convert to utf-8 and/or honors CHARSET.
Not converting seems to work best. Fix it if problem arises.
git-svn-id: svn://svn.mplayerhq.hu/mplayer/trunk@24106 b3059339-0415-0410-9bf9-f77b7e298cf2
Diffstat (limited to 'gui/interface.h')
-rw-r--r-- | gui/interface.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/gui/interface.h b/gui/interface.h index c6cbe4fe4d..26a885a9d8 100644 --- a/gui/interface.h +++ b/gui/interface.h @@ -210,7 +210,6 @@ extern float gtkEquChannels[6][10]; extern void * gtkSet( int cmd,float param, void * vparam ); -extern char * gconvert_uri_to_filename( char * str ); extern char * gstrdup( const char * str ); extern int gstrcmp( const char * a,const char * b ); extern void gfree( void ** p ); |