Patch by Stefan Huehner / stefan % huehner ! org \

patch replaces '()' for the correct '(void)' in function
declarations/prototypes which have no parameters. The '()' syntax tell
thats there is a variable list of arguments, so that the compiler cannot
check this. The extra CFLAG '-Wstrict-declarations' shows those cases.

Comments about a similar patch applied to ffmpeg:

That in C++ these mean the same, but in ANSI C the semantics are
different; function() is an (obsolete) K&R C style forward declaration,
it basically means that the function can have any number and any types
of parameters, effectively completely preventing the compiler from doing
any sort of type checking. -- Erik Slagter

Defining functions with unspecified arguments is allowed but bad.
With arguments unspecified the compiler can't report an error/warning
if the function is called with incorrect arguments. -- Måns Rullgård


git-svn-id: svn://svn.mplayerhq.hu/mplayer/trunk@17567 b3059339-0415-0410-9bf9-f77b7e298cf2

1 files changed, 5 insertions, 5 deletions

diff --git a/divx4_vbr.c b/divx4_vbr.c
index 467f776910..f1d504cfed 100644
--- a/divx4_vbr.c
+++ b/divx4_vbr.c
@@ -316,17 +316,17 @@ int VbrControl_init_2pass_vbr_encoding(const char *filename, int bitrate, double
 	return 0;
 }
 
-int VbrControl_get_intra() 
+int VbrControl_get_intra(void) 
 {
 	return m_vFrames[m_iCount].is_key_frame;
 }
 
-short VbrControl_get_drop() 
+short VbrControl_get_drop(void) 
 {
 	return m_bDrop;
 }
 
-int VbrControl_get_quant() 
+int VbrControl_get_quant(void) 
 {
 	return m_iQuant;
 }
@@ -340,7 +340,7 @@ void VbrControl_set_quant(float quant)
 	if(m_iQuant>max_quantizer) m_iQuant=max_quantizer;
 }
 
-void VbrControl_update_1pass_vbr()
+void VbrControl_update_1pass_vbr(void)
 {
 	VbrControl_set_quant(m_fQuant);
 	m_iCount++;
@@ -395,7 +395,7 @@ void VbrControl_update_2pass_vbr_encoding(int motion_bits, int texture_bits, int
 		fprintf(m_pFile, ", new quant %d\n", m_iQuant);
 }
 
-void VbrControl_close()
+void VbrControl_close(void)
 {
 	if(m_pFile)
 	{