osd: fix OSD status symbol display in some cases

The playback status symbol in the OSD status display on video (such as
displayed when seeking or with the show_progress input command)
sometimes kept displaying the last seek, without resetting the symbol.
(For example: disable the OSD, seek, enable the OSD, run show_progress;
but also other cases.)

The main reason for that was the code clearing the OSD bar is also
responsible for clearing the osd_function (which stores the playback
symbol). If no OSD bar was set, the osd_function was never reset.

Fix by always setting the timer for clearing the OSD bar and the
osd_function whenever the osd_function is set. Clearing the OSD bar
when it wasn't set is OK. If the OSD bar is set some time after
osd_function is set, the timer is overwritten - that's a good thing,
as it makes both disappear from the screen at exactly the same time.

Always reset osd_function to 0 and determine the playback status
explicitly from mpctx->paused when displaying the status on screen.

1 files changed, 1 insertions, 1 deletions

diff --git a/core/mp_core.h b/core/mp_core.h
index 0439ca13f5..dac4dd26d0 100644
--- a/core/mp_core.h
+++ b/core/mp_core.h
@@ -137,8 +137,8 @@ typedef struct MPContext {
 
     int add_osd_seek_info; // bitfield of enum mp_osd_seek_info
     unsigned int osd_visible;
-
     int osd_function;
+
     struct playlist *playlist;
     char *filename; // currently playing file
     struct mp_resolve_result *resolve_result;