af: don't require filters to allocate af_instance->data, redo buffers

Allocate af_instance->data in generic code before filter initialization.
Every filter needs af->data (since it contains the output
configuration), so there's no reason why every filter should allocate
and free it.

Remove RESIZE_LOCAL_BUFFER(), and replace it with mp_audio_realloc_min().
Interestingly, most code becomes simpler, because the new function takes
the size in samples, and not in bytes. There are larger change in
af_scaletempo.c and af_lavcac3enc.c, because these had copied and
modified versions of the RESIZE_LOCAL_BUFFER macro/function.

1 files changed, 0 insertions, 7 deletions

diff --git a/audio/filter/af_ladspa.c b/audio/filter/af_ladspa.c
index 6acdc150d7..3a6c258a89 100644
--- a/audio/filter/af_ladspa.c
+++ b/audio/filter/af_ladspa.c
@@ -646,7 +646,6 @@ static int control(struct af_instance *af, int cmd, void *arg) {
  */
 
 static void uninit(struct af_instance *af) {
-    free(af->data);
     if (af->setup) {
         af_ladspa_t *setup = (af_ladspa_t*) af->setup;
         const LADSPA_Descriptor *pdes = setup->plugin_descriptor;
@@ -878,14 +877,8 @@ static int af_open(struct af_instance *af) {
     af->play=play;
     af->mul=1;
 
-    af->data = calloc(1, sizeof(struct mp_audio));
-    if (af->data == NULL)
-        return af_ladspa_malloc_failed((char*)af_info_ladspa.name);
-
     af->setup = calloc(1, sizeof(af_ladspa_t));
     if (af->setup == NULL) {
-        free(af->data);
-        af->data=NULL;
         return af_ladspa_malloc_failed((char*)af_info_ladspa.name);
     }