af: don't require filters to allocate af_instance->data, redo buffers

Allocate af_instance->data in generic code before filter initialization.
Every filter needs af->data (since it contains the output
configuration), so there's no reason why every filter should allocate
and free it.

Remove RESIZE_LOCAL_BUFFER(), and replace it with mp_audio_realloc_min().
Interestingly, most code becomes simpler, because the new function takes
the size in samples, and not in bytes. There are larger change in
af_scaletempo.c and af_lavcac3enc.c, because these had copied and
modified versions of the RESIZE_LOCAL_BUFFER macro/function.

1 files changed, 1 insertions, 10 deletions

diff --git a/audio/filter/af_convert24.c b/audio/filter/af_convert24.c
index 96924de344..19904cc8e7 100644
--- a/audio/filter/af_convert24.c
+++ b/audio/filter/af_convert24.c
@@ -74,8 +74,7 @@ static int control(struct af_instance *af, int cmd, void *arg)
 
 static struct mp_audio *play(struct af_instance *af, struct mp_audio *data)
 {
-    if (RESIZE_LOCAL_BUFFER(af, data) != AF_OK)
-        return NULL;
+    mp_audio_realloc_min(af->data, data->samples);
 
     struct mp_audio *out = af->data;
     size_t len = mp_audio_psize(data) / data->bps;
@@ -104,18 +103,10 @@ static struct mp_audio *play(struct af_instance *af, struct mp_audio *data)
     return data;
 }
 
-static void uninit(struct af_instance* af)
-{
-    if (af->data)
-        free(af->data->planes[0]);
-}
-
 static int af_open(struct af_instance *af)
 {
     af->control = control;
     af->play = play;
-    af->uninit = uninit;
-    af->data = talloc_zero(af, struct mp_audio);
     return AF_OK;
 }