diff options
| author | Dudemanguy <random342@airmail.cc> | 2023-07-24 12:16:12 -0500 |
|---|---|---|
| committer | Niklas Haas <github-daiK1o@haasn.dev> | 2023-07-29 22:22:37 +0200 |
| commit | a2dd78fbc0932a4f47edbe4c41fe268095075c88 (patch) | |
| tree | 654948410a10761a42616dbb680762385be756bf /DOCS/man/options.rst | |
| parent | 3bf1d22879c90fbde99bce1d3a6a54e86d298a5e (diff) | |
| download | mpv-a2dd78fbc0932a4f47edbe4c41fe268095075c88.tar.bz2 mpv-a2dd78fbc0932a4f47edbe4c41fe268095075c88.tar.xz | |
options: restore old default sub selection behavior
1669c4698d237eb885aa3f9c5b81983de6009418 notably flipped the default of
--subs-with-matching-audio from yes to no as part of a series of changes
that gave more control over sub selection behavior. While the increased
amount of options is definitely nice, changing the default to no results
in very unintuitive behavior. For example, setting alang=en and slang=en
in your config will not show any subtitles since the audio stream is
English as well so --subs-with-matching-audio being no causes the subs
to not be be selected. This is very weird for users who reasonably
expect slang being set to actually result in showing subs and this is
what mpv did for the past decade.
The other case is when a subtitle does not have a language tag but is
flagged as default. Because --subs-fallback (a new option), defaults to
no, these subtitles also will not be loaded. This is also strange for
users since mpv previously loaded these and they would need to change
the value of this option. It's also inconsistent because audio tracks
that are tagged as default are also loaded by default.
The new behavior seems to have mostly just confused users, and it also
regresses their configs for unclear reasons. Let's just set the options
to be back in line with the old behavior with is what most users expect.
--subs-with-matching-audio goes back to being yes and the new option
--subs-fallback should be default. Fixes #11854.
Diffstat (limited to 'DOCS/man/options.rst')
| -rw-r--r-- | DOCS/man/options.rst | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/DOCS/man/options.rst b/DOCS/man/options.rst index 10c6ace9ae..b50d244de1 100644 --- a/DOCS/man/options.rst +++ b/DOCS/man/options.rst @@ -140,11 +140,11 @@ Track Selection ``--subs-with-matching-audio=<yes|no>`` When autoselecting a subtitle track, select a full/non-forced one even if the selected - audio stream matches your preferred subtitle language (default: no). + audio stream matches your preferred subtitle language (default: yes). ``--subs-fallback=<yes|default|no>`` When autoselecting a subtitle track, if no tracks match your preferred languages, - select a full track even if it doesn't match your preferred subtitle language (default: no). + select a full track even if it doesn't match your preferred subtitle language (default: default). Setting this to `default` means that only streams flagged as `default` will be selected. ``--subs-fallback-forced=<yes|no>`` |