summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorder richter <der.richter@gmx.de>2024-03-03 15:39:07 +0100
committerder richter <der.richter@gmx.de>2024-03-07 01:03:52 +0100
commiteadd85a6ac11dd824226a43765fad2cfb42b8cb3 (patch)
tree50211b2ecc2b1d70d6685cd77f627cd648b5127c
parentcb807ff063739fbbdc2a0f702916d16c9ca713e5 (diff)
downloadmpv-eadd85a6ac11dd824226a43765fad2cfb42b8cb3.tar.bz2
mpv-eadd85a6ac11dd824226a43765fad2cfb42b8cb3.tar.xz
mac/menu: optimise loading files function
don't save files in a temporary array and use an in place mapping.
-rw-r--r--osdep/mac/menu_bar.swift10
1 files changed, 3 insertions, 7 deletions
diff --git a/osdep/mac/menu_bar.swift b/osdep/mac/menu_bar.swift
index d8158598a1..c236995d54 100644
--- a/osdep/mac/menu_bar.swift
+++ b/osdep/mac/menu_bar.swift
@@ -106,7 +106,7 @@ class MenuBar: NSObject {
]
let fileMenuConfigs = [
- Config(name: "Open File…", key: "o", action: #selector(openFile), target: self),
+ Config(name: "Open File…", key: "o", action: #selector(openFiles), target: self),
Config(name: "Open URL…", key: "O", action: #selector(openUrl), target: self),
Config(name: "Open Playlist…", action: #selector(openPlaylist), target: self),
Config(name: "separator"),
@@ -329,17 +329,13 @@ class MenuBar: NSObject {
}
}
- @objc func openFile() {
+ @objc func openFiles() {
let panel = NSOpenPanel()
panel.allowsMultipleSelection = true
panel.canChooseDirectories = true
if panel.runModal() == .OK {
- var files: [String] = []
- for url in panel.urls {
- files += [url.path]
- }
- (NSApp as? Application)?.openFiles(files)
+ (NSApp as? Application)?.openFiles(panel.urls.map { $0.path })
}
}