diff options
author | Niklas Haas <git@haasn.dev> | 2023-09-16 13:41:18 +0200 |
---|---|---|
committer | Niklas Haas <github-daiK1o@haasn.dev> | 2023-09-16 14:33:45 +0200 |
commit | bc351809333702b2243d24febf1aa14573bc2f58 (patch) | |
tree | c54338360a1dcae5523c4cedca336270b01f2ee2 | |
parent | a24aa6b8f7a30c5ac767c1a44b4c973372a79be5 (diff) | |
download | mpv-bc351809333702b2243d24febf1aa14573bc2f58.tar.bz2 mpv-bc351809333702b2243d24febf1aa14573bc2f58.tar.xz |
vo_gpu: remove --scale-wblur etc
No need for this since it's entirely redundant with just changing the
filter radius directly. In fact, that's the whole *point* of the filter
radius - it does not modify the filter, it modifies the scaling of the
window.
Of course, this does not work for non-resizable kernels. But, really,
who cares?
-rw-r--r-- | DOCS/interface-changes.rst | 1 | ||||
-rw-r--r-- | DOCS/man/options.rst | 12 | ||||
-rw-r--r-- | video/out/gpu/video.c | 2 |
3 files changed, 8 insertions, 7 deletions
diff --git a/DOCS/interface-changes.rst b/DOCS/interface-changes.rst index f7e4d7c0da..ea4b8cfe6f 100644 --- a/DOCS/interface-changes.rst +++ b/DOCS/interface-changes.rst @@ -59,6 +59,7 @@ Interface changes - change `--subs-fallback-forced` so that it works alongside `--slang` - add `--icc-3dlut-size=auto` and make it the default - add `--scale=ewa_lanczos4sharpest` + - remove `--scale-wblur`, `--cscale-wblur`, `--dscale-wblur`, `--tscale-wblur` --- mpv 0.36.0 --- - add `--target-contrast` - Target luminance value is now also applied when ICC profile is used. diff --git a/DOCS/man/options.rst b/DOCS/man/options.rst index 7e0a07bdb1..e78f8b1a24 100644 --- a/DOCS/man/options.rst +++ b/DOCS/man/options.rst @@ -5351,12 +5351,12 @@ them. never interpolate, thus behaving as if the regular nearest neighbour algorithm was used. Defaults to 0.0. -``--scale-blur=<value>``, ``--scale-wblur=<value>``, ``--cscale-blur=<value>``, ``--cscale-wblur=<value>``, ``--dscale-blur=<value>``, ``--dscale-wblur=<value>``, ``--tscale-blur=<value>``, ``--tscale-wblur=<value>`` - Kernel/window scaling factor (also known as a blur factor). Decreasing this - makes the result sharper, increasing it makes it blurrier (default 0). If - set to 0, the kernel's preferred blur factor is used. Note that setting - this too low (eg. 0.5) leads to bad results. It's generally recommended to - stick to values between 0.8 and 1.2. +``--scale-blur=<value>``, ``--cscale-blur=<value>``, ``--dscale-blur=<value>``, ``--tscale-blur=<value>`` + Kernel scaling factor (also known as a blur factor). Decreasing this makes + the result sharper, increasing it makes it blurrier (default 0). If set to + 0, the kernel's preferred blur factor is used. Note that setting this too + low (eg. 0.5) leads to bad results. It's generally recommended to stick to + values between 0.8 and 1.2. ``--scale-clamp=<0.0-1.0>``, ``--cscale-clamp``, ``--dscale-clamp``, ``--tscale-clamp`` Specifies a weight bias to multiply into negative coefficients. Specifying diff --git a/video/out/gpu/video.c b/video/out/gpu/video.c index e9e05ed824..510915a1db 100644 --- a/video/out/gpu/video.c +++ b/video/out/gpu/video.c @@ -356,7 +356,7 @@ static int validate_error_diffusion_opt(struct mp_log *log, const m_option_t *op {n"-cutoff", OPT_FLOAT(scaler[i].cutoff), M_RANGE(0.0, 1.0)}, \ {n"-taper", OPT_FLOAT(scaler[i].kernel.taper), M_RANGE(0.0, 1.0)}, \ {n"-wparam", OPT_FLOATDEF(scaler[i].window.params[0])}, \ - {n"-wblur", OPT_FLOAT(scaler[i].window.blur)}, \ + {n"-wblur", OPT_REMOVED("Just adjust filter radius directly")}, \ {n"-wtaper", OPT_FLOAT(scaler[i].window.taper), M_RANGE(0.0, 1.0)}, \ {n"-clamp", OPT_FLOAT(scaler[i].clamp), M_RANGE(0.0, 1.0)}, \ {n"-radius", OPT_FLOAT(scaler[i].radius), M_RANGE(0.5, 16.0)}, \ |