summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorsfan5 <sfan5@live.de>2024-03-21 15:27:53 +0100
committersfan5 <sfan5@live.de>2024-03-24 09:58:41 +0100
commit8e3737ab633ba096fcf9f2da2391f84690bd1b4c (patch)
tree2f5884b32407ebd02c20469633b3762b35fb0cb5
parent7490919a9accc5b9f4721e09fb445d217d691897 (diff)
downloadmpv-8e3737ab633ba096fcf9f2da2391f84690bd1b4c.tar.bz2
mpv-8e3737ab633ba096fcf9f2da2391f84690bd1b4c.tar.xz
ao_pulse: reenable latency hacks by default
As far as I can tell PulseAudio introduced a bug in 16.0 where if a stream is (un)paused too often the reported latency will momentarily spike by 3000% or more. Apparently in certain cases just pausing once and waiting can also cause this. Save the remaining users of PA the trouble of debugging the various obscure issues that can arise from this (desync is a harmless example) by enabling the latency hack code again. ref: <https://github.com/mpv-player/mpv/issues/12057> <https://github.com/mpv-player/mpv/issues/10333>
-rw-r--r--DOCS/interface-changes/pa-defaults.txt1
-rw-r--r--audio/out/ao_pulse.c1
2 files changed, 2 insertions, 0 deletions
diff --git a/DOCS/interface-changes/pa-defaults.txt b/DOCS/interface-changes/pa-defaults.txt
new file mode 100644
index 0000000000..7298de173a
--- /dev/null
+++ b/DOCS/interface-changes/pa-defaults.txt
@@ -0,0 +1 @@
+change `--pulse-latency-hacks` default to `yes`
diff --git a/audio/out/ao_pulse.c b/audio/out/ao_pulse.c
index 3b29b1a3ad..68e7a71494 100644
--- a/audio/out/ao_pulse.c
+++ b/audio/out/ao_pulse.c
@@ -804,6 +804,7 @@ const struct ao_driver audio_out_pulse = {
.priv_size = sizeof(struct priv),
.priv_defaults = &(const struct priv) {
.cfg_buffer = 100,
+ .cfg_latency_hacks = true,
},
.options = (const struct m_option[]) {
{"host", OPT_STRING(cfg_host)},