diff options
| author | nanahi <130121847+na-na-hi@users.noreply.github.com> | 2024-03-14 21:48:14 -0400 |
|---|---|---|
| committer | Dudemanguy <random342@airmail.cc> | 2024-03-17 14:59:26 +0000 |
| commit | 8a9749b8a563f258342450160c98e9c02ebedc96 (patch) | |
| tree | 47a9f43128f573155a7fbb0dd5afac3ed7f8c0e7 | |
| parent | b2ce96bd358a1f7ab70f09ec77b1fa69e61aa70e (diff) | |
| download | mpv-8a9749b8a563f258342450160c98e9c02ebedc96.tar.bz2 mpv-8a9749b8a563f258342450160c98e9c02ebedc96.tar.xz | |
wayland_common: respect compositor's preferenced size on state change
Currently mpv always uses the previous window size when unmaximizing
or exiting fullscreen. This disregards compositor's preferenced size in
the configure event, resulting in wrong window size if changing window
state and size are delivered in the same configure event.
It's better to always respect the preferenced size instead, unless
the state change is due to runtime geometry change, where we want
to use our preference.
| -rw-r--r-- | video/out/wayland_common.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/video/out/wayland_common.c b/video/out/wayland_common.c index 5646c84bb7..1185678d18 100644 --- a/video/out/wayland_common.c +++ b/video/out/wayland_common.c @@ -1099,13 +1099,11 @@ static void handle_toplevel_config(void *data, struct xdg_toplevel *toplevel, wl->hidden = is_suspended; if (vo_opts->fullscreen != is_fullscreen) { - wl->state_change = true; vo_opts->fullscreen = is_fullscreen; m_config_cache_write_opt(wl->vo_opts_cache, &vo_opts->fullscreen); } if (vo_opts->window_maximized != is_maximized) { - wl->state_change = true; vo_opts->window_maximized = is_maximized; m_config_cache_write_opt(wl->vo_opts_cache, &vo_opts->window_maximized); } @@ -2142,7 +2140,6 @@ static int spawn_cursor(struct vo_wayland_state *wl) static void toggle_fullscreen(struct vo_wayland_state *wl) { - wl->state_change = true; bool specific_screen = wl->vo_opts->fsscreen_id >= 0 || wl->vo_opts->fsscreen_name; if (wl->vo_opts->fullscreen && !specific_screen) { xdg_toplevel_set_fullscreen(wl->xdg_toplevel, NULL); @@ -2156,7 +2153,6 @@ static void toggle_fullscreen(struct vo_wayland_state *wl) static void toggle_maximized(struct vo_wayland_state *wl) { - wl->state_change = true; if (wl->vo_opts->window_maximized) { xdg_toplevel_set_maximized(wl->xdg_toplevel); } else { @@ -2314,6 +2310,7 @@ int vo_wayland_control(struct vo *vo, int *events, int request, void *arg) if (opt == &opts->geometry || opt == &opts->autofit || opt == &opts->autofit_smaller || opt == &opts->autofit_larger) { + wl->state_change = true; set_geometry(wl, true); } } @@ -2352,6 +2349,7 @@ int vo_wayland_control(struct vo *vo, int *events, int request, void *arg) wl->window_size.x1 = s[0]; wl->window_size.y1 = s[1]; if (!wl->vo_opts->fullscreen && !wl->tiled) { + wl->state_change = true; if (wl->vo_opts->window_maximized) { xdg_toplevel_unset_maximized(wl->xdg_toplevel); wl_display_dispatch_pending(wl->display); |