summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNiklas Haas <git@haasn.xyz>2017-09-29 00:48:39 +0200
committerNiklas Haas <git@haasn.xyz>2017-09-29 00:48:39 +0200
commitf6fd2a05c4249ff4eeb8b0d1be4e40a5a1c6177a (patch)
tree7913e6d60a9b8a42483f12dd7311af915817a0e6
parent22311a767d863633d29f136385d4eef4fad8fde8 (diff)
downloadmpv-f6fd2a05c4249ff4eeb8b0d1be4e40a5a1c6177a.tar.bz2
mpv-f6fd2a05c4249ff4eeb8b0d1be4e40a5a1c6177a.tar.xz
vo_gpu: vulkan: reword comment
This is fixed upstream (and we now know it's a driver bug) so reword the comment.
-rw-r--r--video/out/vulkan/context.c7
1 files changed, 4 insertions, 3 deletions
diff --git a/video/out/vulkan/context.c b/video/out/vulkan/context.c
index c2cc2d5081..0bca198e50 100644
--- a/video/out/vulkan/context.c
+++ b/video/out/vulkan/context.c
@@ -477,9 +477,10 @@ static bool submit_frame(struct ra_swapchain *sw, const struct vo_frame *frame)
&p->frames_in_flight))
goto error;
- // For some reason, nvidia absolutely shits itself when presenting from a
- // full queue - so advance all of the cmdpool indices first and then do the
- // present on an "empty" queue
+ // Older nvidia drivers can spontaneously combust when submitting to the
+ // same queue as we're rendering from, in a multi-queue scenario. Safest
+ // option is to cycle the queues first and then submit to the next queue.
+ // We can drop this hack in the future, I suppose.
vk_cmd_cycle_queues(vk);
struct vk_cmdpool *pool = vk->pool;
VkQueue queue = pool->queues[pool->qindex];