From 3b8b7cb9d481828953f105f92bacc07a3cb2f332 Mon Sep 17 00:00:00 2001 From: wm4 Date: Thu, 5 Mar 2020 10:55:36 +0100 Subject: stream_smb: remove this This required libsmbclient, which is a heavy dependency, and as a library, has all kinds of problems. For one, the API requires completely unacceptable global state (in particular, leaks auth state), and is not thread-safe (meaning concurrent reads to multiple files block each other). There are better replacements: you can use the Linux kernel's builtin CIFS support, fusesmb, or contribute supoport for libdsm. --- wscript | 7 ------- 1 file changed, 7 deletions(-) (limited to 'wscript') diff --git a/wscript b/wscript index 7506b1bceb..71574e79ac 100644 --- a/wscript +++ b/wscript @@ -326,13 +326,6 @@ iconv support use --disable-iconv.", 'deps': 'os-linux', 'func': check_statement('sys/mman.h', 'memfd_create("mpv", MFD_CLOEXEC | MFD_ALLOW_SEALING)') - }, { - 'name': '--libsmbclient', - 'desc': 'Samba support (makes mpv GPLv3)', - 'deps': 'libdl && gpl', - 'func': check_pkg_config('smbclient'), - 'default': 'disable', - 'module': 'input', }, { 'name' : '--lua', 'desc' : 'Lua', -- cgit v1.2.3