From f6fd2a05c4249ff4eeb8b0d1be4e40a5a1c6177a Mon Sep 17 00:00:00 2001 From: Niklas Haas Date: Fri, 29 Sep 2017 00:48:39 +0200 Subject: vo_gpu: vulkan: reword comment This is fixed upstream (and we now know it's a driver bug) so reword the comment. --- video/out/vulkan/context.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'video') diff --git a/video/out/vulkan/context.c b/video/out/vulkan/context.c index c2cc2d5081..0bca198e50 100644 --- a/video/out/vulkan/context.c +++ b/video/out/vulkan/context.c @@ -477,9 +477,10 @@ static bool submit_frame(struct ra_swapchain *sw, const struct vo_frame *frame) &p->frames_in_flight)) goto error; - // For some reason, nvidia absolutely shits itself when presenting from a - // full queue - so advance all of the cmdpool indices first and then do the - // present on an "empty" queue + // Older nvidia drivers can spontaneously combust when submitting to the + // same queue as we're rendering from, in a multi-queue scenario. Safest + // option is to cycle the queues first and then submit to the next queue. + // We can drop this hack in the future, I suppose. vk_cmd_cycle_queues(vk); struct vk_cmdpool *pool = vk->pool; VkQueue queue = pool->queues[pool->qindex]; -- cgit v1.2.3