From c473688c5f4177295d7e6f8c67148ded70b77e2e Mon Sep 17 00:00:00 2001 From: wm4 Date: Wed, 31 Dec 2014 21:04:29 +0100 Subject: gl_hwdec_vda: refuse to work with old OpenGL versions The way we use rectangle textures (required by VDA for no reason) works onl in OpenGL 3.0 or higher. Below that, the shader will fail to compile. We could add support for older OpenGL versions, but that would be a major pain. This normally doesn't matter; mpv itself always creates OpenGL 3.2 contexts on OSX. But it could matter if a client API user uses vo_opengl_cb, and gives it a 2.1 context (which OSX also allows you to create). Conflicts: video/out/gl_hwdec_vda.c --- video/out/gl_hwdec_vda.c | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'video') diff --git a/video/out/gl_hwdec_vda.c b/video/out/gl_hwdec_vda.c index c86c1abb34..47bdb3ebfa 100644 --- a/video/out/gl_hwdec_vda.c +++ b/video/out/gl_hwdec_vda.c @@ -40,6 +40,11 @@ static bool check_hwdec(struct gl_hwdec *hw) return false; } + if (hw->mpgl->gl->version < 300) { + MP_ERR(hw, "need >= OpenGL 3.0 for core rectangle texture support\n"); + return false; + } + if (!vo->cocoa) { MP_ERR(hw, "need cocoa opengl backend to be active"); return false; -- cgit v1.2.3