From c0b8c35e3ba858ef8e5e47ebc45ccaa88ef86348 Mon Sep 17 00:00:00 2001 From: Alexander Preisinger Date: Thu, 2 May 2013 20:03:15 +0200 Subject: wayland: use new function xkb_keymap_from_buffer Bump xkbcommon version and use the new xkb_keymap_from_buffer. This is more secure, because the from_string expects a 0 terminated string, but this cannot be guaranteed with mmap. --- video/out/wayland_common.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) (limited to 'video') diff --git a/video/out/wayland_common.c b/video/out/wayland_common.c index 8c8033f87a..0bcd9395be 100644 --- a/video/out/wayland_common.c +++ b/video/out/wayland_common.c @@ -217,15 +217,10 @@ static void keyboard_handle_keymap(void *data, int32_t fd, uint32_t size) { - struct vo_wayland_input *input = ((struct vo_wayland_state *) data)->input; + struct vo_wayland_input *input; char *map_str; - if(!data) { - close(fd); - return; - } - - if (format != WL_KEYBOARD_KEYMAP_FORMAT_XKB_V1) { + if(!data || format != WL_KEYBOARD_KEYMAP_FORMAT_XKB_V1) { close(fd); return; } @@ -236,8 +231,9 @@ static void keyboard_handle_keymap(void *data, return; } - input->xkb.keymap = xkb_map_new_from_string(input->xkb.context, - map_str, XKB_KEYMAP_FORMAT_TEXT_V1, 0); + input = ((struct vo_wayland_state *) data)->input; + input->xkb.keymap = xkb_keymap_new_from_buffer(input->xkb.context, + map_str, size, XKB_KEYMAP_FORMAT_TEXT_V1, 0); munmap(map_str, size); close(fd); -- cgit v1.2.3