From 6b4f560f3ccca0f7db345bd7a6ed65e9307b432d Mon Sep 17 00:00:00 2001 From: wm4 Date: Thu, 1 Sep 2016 14:21:32 +0200 Subject: vo, ao: disable positional parameter suboptions Positional parameters cause problems because they can be ambiguous with flag options. If a flag option is removed or turned into a non-flag option, it'll usually be interpreted as value for the first sub-option (as positional parameter), resulting in very confusing error messages. This changes it into a simple "option not found" error. I don't expect that anyone really used positional parameters with --vo or --ao. Although the docs for --ao=pulse seem to encourage positional parameters for the host/sink options, which means it could possibly annoy some PulseAudio users. --vf and --af are still mostly used with positional parameters, so this must be a configurable option in the option parser. --- video/out/vo.c | 1 + 1 file changed, 1 insertion(+) (limited to 'video') diff --git a/video/out/vo.c b/video/out/vo.c index 31a1e74405..53525b4049 100644 --- a/video/out/vo.c +++ b/video/out/vo.c @@ -193,6 +193,7 @@ const struct m_obj_list vo_obj_list = { }, .allow_unknown_entries = true, .allow_trailer = true, + .disallow_positional_parameters = true, }; static void dispatch_wakeup_cb(void *ptr) -- cgit v1.2.3