From 3cd29ca0318cfab04d155ea8323e7b4c84010b79 Mon Sep 17 00:00:00 2001 From: wm4 Date: Tue, 21 Feb 2017 14:18:30 +0100 Subject: player: reduce blocking on VO when switching pause When pausing, we sent BOCTRL_PAUSE and VOCTRL_RESTORE_SCREENSAVER. These essentially wait until the video frame has been rendered. This is a problem with the opengl-cb, if GL rendering is done in the same thread as libmpv uses. Unfortunately, it's allowed to use opengl-cb this way. Logically speaking, it's a deadlock situation, which is resolved with a timeout. This can lead to quite ugly effects, like the on-pause frame not being rendered until the timeout has passed. It has been interpreted as video continuing to play. Resolve this by simply not blocking on pause. Make the screensaver controls async, and handle sending VOCTRL_PAUSE in the VO thread. (All this could be avoided by redoing the internal VO API.) Also see #4152. --- video/out/vo.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) (limited to 'video') diff --git a/video/out/vo.c b/video/out/vo.c index f0c865d269..3eb338d2d7 100644 --- a/video/out/vo.c +++ b/video/out/vo.c @@ -581,6 +581,9 @@ void vo_control_async(struct vo *vo, int request, void *data) case VOCTRL_UPDATE_PLAYBACK_STATE: d[2] = ta_xdup_ptrtype(d, (struct voctrl_playback_state *)data); break; + case VOCTRL_KILL_SCREENSAVER: + case VOCTRL_RESTORE_SCREENSAVER: + break; default: abort(); // requires explicit support } @@ -933,9 +936,13 @@ static void *vo_thread(void *ptr) bool redraw = in->request_redraw; bool send_reset = in->send_reset; in->send_reset = false; + bool send_pause = in->paused != vo_paused; + vo_paused = in->paused; pthread_mutex_unlock(&in->lock); if (send_reset) vo->driver->control(vo, VOCTRL_RESET, NULL); + if (send_pause) + vo->driver->control(vo, vo_paused ? VOCTRL_PAUSE : VOCTRL_RESUME, NULL); if (wait_until > now && redraw) { do_redraw(vo); // now is a good time continue; @@ -958,9 +965,9 @@ void vo_set_paused(struct vo *vo, bool paused) if (in->paused && in->dropped_frame) in->request_redraw = true; reset_vsync_timings(vo); + wakeup_locked(vo); } pthread_mutex_unlock(&in->lock); - vo_control(vo, paused ? VOCTRL_PAUSE : VOCTRL_RESUME, NULL); } int64_t vo_get_drop_count(struct vo *vo) -- cgit v1.2.3