From 66e20ef8ad0c3e3ce420f08fa7849000a4cc060a Mon Sep 17 00:00:00 2001 From: wm4 Date: Thu, 5 Dec 2013 22:55:35 +0100 Subject: video: remove --flip The --flip option flipped the image upside-down, by trying to use VO support, or if not available, by inserting a video filter. I'm not sure why it existed. Maybe it was important in ancient times when VfW based decoders output an image this way (but even then, flipping an image is a free operation by negating the stride). One nice thing about this is that it provided a possible path for implementing video orientation, which is a feature we should probably support eventually. The important part is that it would be for free for VOs that support it, and would work even with hardware decoding. But for now get rid of it. It's useless, trivial, stands in the way, and supporting video orientation would require solving other problems first. --- video/out/vo_opengl.c | 2 +- video/out/vo_opengl_old.c | 2 +- video/out/vo_sdl.c | 2 +- video/out/vo_vdpau.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) (limited to 'video/out') diff --git a/video/out/vo_opengl.c b/video/out/vo_opengl.c index 774d87ed05..714bbf4e6b 100644 --- a/video/out/vo_opengl.c +++ b/video/out/vo_opengl.c @@ -138,7 +138,7 @@ static void draw_image(struct vo *vo, mp_image_t *mpi) static int query_format(struct vo *vo, uint32_t format) { struct gl_priv *p = vo->priv; - int caps = VFCAP_CSP_SUPPORTED | VFCAP_CSP_SUPPORTED_BY_HW | VFCAP_FLIP; + int caps = VFCAP_CSP_SUPPORTED | VFCAP_CSP_SUPPORTED_BY_HW; if (!gl_video_check_format(p->renderer, format)) return 0; return caps; diff --git a/video/out/vo_opengl_old.c b/video/out/vo_opengl_old.c index cd4b6915ca..5ae8816900 100644 --- a/video/out/vo_opengl_old.c +++ b/video/out/vo_opengl_old.c @@ -2039,7 +2039,7 @@ static int query_format(struct vo *vo, uint32_t format) struct mp_imgfmt_desc desc = mp_imgfmt_get_desc(format); int depth = desc.plane_bits; - int caps = VFCAP_CSP_SUPPORTED | VFCAP_CSP_SUPPORTED_BY_HW | VFCAP_FLIP; + int caps = VFCAP_CSP_SUPPORTED | VFCAP_CSP_SUPPORTED_BY_HW; if (format == IMGFMT_RGB24 || format == IMGFMT_RGBA) return caps; if (p->use_yuv && (desc.flags & MP_IMGFLAG_YUV_P) && diff --git a/video/out/vo_sdl.c b/video/out/vo_sdl.c index 86643788b9..384df54b3a 100644 --- a/video/out/vo_sdl.c +++ b/video/out/vo_sdl.c @@ -772,7 +772,7 @@ static int query_format(struct vo *vo, uint32_t format) { struct priv *vc = vo->priv; int i, j; - int cap = VFCAP_CSP_SUPPORTED | VFCAP_FLIP; + int cap = VFCAP_CSP_SUPPORTED; for (i = 0; i < vc->renderer_info.num_texture_formats; ++i) for (j = 0; j < sizeof(formats) / sizeof(formats[0]); ++j) if (vc->renderer_info.texture_formats[i] == formats[j].sdl) diff --git a/video/out/vo_vdpau.c b/video/out/vo_vdpau.c index 727fea532f..082ad1a05d 100644 --- a/video/out/vo_vdpau.c +++ b/video/out/vo_vdpau.c @@ -1272,7 +1272,7 @@ static int query_format(struct vo *vo, uint32_t format) { struct vdpctx *vc = vo->priv; - int flags = VFCAP_CSP_SUPPORTED | VFCAP_CSP_SUPPORTED_BY_HW | VFCAP_FLIP; + int flags = VFCAP_CSP_SUPPORTED | VFCAP_CSP_SUPPORTED_BY_HW; if (mp_vdpau_get_format(format, NULL, NULL)) return flags; int rgb_format = get_rgb_format(format); -- cgit v1.2.3