From b926f189388918e623ebda65d6a47a7ab00b9cfc Mon Sep 17 00:00:00 2001 From: dudemanguy Date: Thu, 30 Jan 2020 11:19:22 -0600 Subject: wayland: remove wayland-frame-wait-offset option This originally existed as a hack for weston. In certain scenarios, a frame taking too long to render would cause vo_wayland_wait_frame to timeout which would result in a ton of dropped frames. The naive solution was to just to add a slight delay to the time value. If a frame took too long, it would likely to fall under the timeout value and all was well. This was exposed to the user since the default delay (1000) was completely arbitrary. However with presentation time, this doesn't appear to be neccesary. Fresh frames that take longer than the display's refresh rate (16.666 ms in most cases) behave well in Weston. In the other two main compositors without presentation time (GNOME and Plasma), they also do not experience any ill effects. It's better not to overcomplicate things, so this "feature" can be removed now. --- video/out/vulkan/context_wayland.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'video/out/vulkan/context_wayland.c') diff --git a/video/out/vulkan/context_wayland.c b/video/out/vulkan/context_wayland.c index a9540411db..83d4617057 100644 --- a/video/out/vulkan/context_wayland.c +++ b/video/out/vulkan/context_wayland.c @@ -111,7 +111,7 @@ static void wayland_vk_swap_buffers(struct ra_ctx *ctx) } if (!wl->opts->disable_vsync) - vo_wayland_wait_frame(wl, wl->opts->frame_offset); + vo_wayland_wait_frame(wl); if (wl->presentation) wayland_sync_swap(wl); -- cgit v1.2.3