From 073858fcddddc757dcfb0e10640d19ac8d6d925d Mon Sep 17 00:00:00 2001 From: Dudemanguy Date: Wed, 14 Feb 2024 11:26:05 -0600 Subject: vo: remove VOCTRL_SET_EQUALIZER and simplify into UPDATE_VIDEO Since 03cf150ff3516789d581214177f291d46310aaf4, the only purpose of this VOCTRL was to signal a redraw to the vo. It actualy could have been removed in 531868fe0d2a35fbbff78d9a9ff8f96df73e69fd, but this was missed. The UPDATE_VIDEO flag is better anyway because it allows us to handle a wide variety of options scattered around that require the VO to update itself and redraw. We can remove both of the custom callbacks in vo.c and only leave the VOCTRL_VO_OPTS_CHANGED one. Additionally, that commit also introduced vo_set_want_redraw, but this is redundant and not needed. The VOs that use VOCTRL_UPDATE_RENDER_OPTS already set vo->want_redraw, and those are the only VOs where these options are relevant in the first place. So we can remove this as well and just let the big callback in player/command do everything. --- video/out/vo_libmpv.c | 3 --- 1 file changed, 3 deletions(-) (limited to 'video/out/vo_libmpv.c') diff --git a/video/out/vo_libmpv.c b/video/out/vo_libmpv.c index 972588ee3e..8a686022a1 100644 --- a/video/out/vo_libmpv.c +++ b/video/out/vo_libmpv.c @@ -608,9 +608,6 @@ static int control(struct vo *vo, uint32_t request, void *data) case VOCTRL_PAUSE: vo->want_redraw = true; return VO_TRUE; - case VOCTRL_SET_EQUALIZER: - vo->want_redraw = true; - return VO_TRUE; case VOCTRL_SET_PANSCAN: mp_mutex_lock(&ctx->lock); ctx->need_resize = true; -- cgit v1.2.3