From d890e0731c0a0c002c32e8be89130e178059d3ba Mon Sep 17 00:00:00 2001 From: wm4 Date: Fri, 20 Jan 2017 13:38:28 +0100 Subject: options: refactor how --opengl-dcomposition is declared vo_opengl used to have it as sub-option, which made it very hard to pass down option values to backends in a generic way (even if these options were completely backend-specific). For --opengl-dcomposition we used a VOFLAG to deal with this. Fortunately, sub-options are gone, and we can just add it as global option. Move the option to context_angle.c and add it as global option. I thought about adding a mechanism to let backends declare options, which would get magically picked up my m_config instead of having to add them to the global option list manually (similar to VO vo_driver.options), but decided against this complexity just for 1 or 2 backends. Likewise, it could have been added as a single option to avoid the boilerplate of an option struct, but then again there are probably going to be more angle suboptions, and it's cleaner. --- video/out/opengl/context.c | 1 + 1 file changed, 1 insertion(+) (limited to 'video/out/opengl/context.c') diff --git a/video/out/opengl/context.c b/video/out/opengl/context.c index fb3471cd3b..478421385c 100644 --- a/video/out/opengl/context.c +++ b/video/out/opengl/context.c @@ -159,6 +159,7 @@ static MPGLContext *init_backend(struct vo *vo, const struct mpgl_driver *driver *ctx = (MPGLContext) { .gl = talloc_zero(ctx, GL), .vo = vo, + .global = vo->global, .driver = driver, }; if (probing) -- cgit v1.2.3