From ac266da6588f25a449a739f7a6a3d2c69ca80e19 Mon Sep 17 00:00:00 2001 From: wm4 Date: Sat, 8 Jun 2013 02:15:24 +0200 Subject: vo_opengl: handle chroma location Use the video decoder chroma location flags and render chroma locations other than centered. Until now, we've always used the intuitive and obvious centered chroma location, but H.264 uses something else. FFmpeg provides a small overview in libavcodec/avcodec.h: ----------- /** * X X 3 4 X X are luma samples, * 1 2 1-6 are possible chroma positions * X X 5 6 X 0 is undefined/unknown position */ enum AVChromaLocation{ AVCHROMA_LOC_UNSPECIFIED = 0, AVCHROMA_LOC_LEFT = 1, ///< mpeg2/4, h264 default AVCHROMA_LOC_CENTER = 2, ///< mpeg1, jpeg, h263 AVCHROMA_LOC_TOPLEFT = 3, ///< DV AVCHROMA_LOC_TOP = 4, AVCHROMA_LOC_BOTTOMLEFT = 5, AVCHROMA_LOC_BOTTOM = 6, AVCHROMA_LOC_NB , ///< Not part of ABI }; ----------- The visual difference is literally minimal, but since videophiles apparently consider this detail as quality mark of a video renderer, support it anyway. We don't bother with chroma locations other than centered and left, though. Not sure about correctness, but it's probably ok. --- video/mp_image.c | 1 + 1 file changed, 1 insertion(+) (limited to 'video/mp_image.c') diff --git a/video/mp_image.c b/video/mp_image.c index 85c174dfaa..95b59eae28 100644 --- a/video/mp_image.c +++ b/video/mp_image.c @@ -324,6 +324,7 @@ void mp_image_copy_attributes(struct mp_image *dst, struct mp_image *src) if ((dst->flags & MP_IMGFLAG_YUV) == (src->flags & MP_IMGFLAG_YUV)) { dst->colorspace = src->colorspace; dst->levels = src->levels; + dst->chroma_location = src->chroma_location; } if (dst->imgfmt == IMGFMT_PAL8 && src->imgfmt == IMGFMT_PAL8) { if (dst->planes[1] && src->planes[1]) -- cgit v1.2.3