From c4b08a9a1149a83d7374eaea9863dd4c7cbd12d7 Mon Sep 17 00:00:00 2001 From: wm4 Date: Thu, 18 Jul 2013 14:05:39 +0200 Subject: video: remove fullscreen flags chaos There was a MPOpts fullscreen field, a mp_vo_opts.fs field, and VOFLAG_FULLSCREEN. Remove all these and introduce a mp_vo_opts.fullscreen flag instead. When VOs receive VOCTRL_FULLSCREEN, they are supposed to set the current fullscreen mode to the state in mp_vo_opts.fullscreen. They also should do this implicitly on config(). VOs which are capable of doing so can update the mp_vo_opts.fullscreen if the actual fullscreen mode changes (e.g. if the user uses the window manager controls). If fullscreen mode switching fails, they can also set mp_vo_opts.fullscreen to the actual state. Note that the X11 backend does almost none of this, and it has a private fs flag to store the fullscreen flag, instead of getting it from the WM. (Possibly because it has to deal with broken WMs.) The fullscreen option has to be checked on config() to deal with the -fs option, especially with something like: mpv --fs file1.mkv --{ --no-fs file2.mkv --} (It should start in fullscreen mode, but go to windowed mode when playing file2.mkv.) Wayland changes by: Alexander Preisinger Cocoa changes by: Stefano Pigozzi --- video/decode/vd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'video/decode/vd.c') diff --git a/video/decode/vd.c b/video/decode/vd.c index 98b9b155df..db038e3d96 100644 --- a/video/decode/vd.c +++ b/video/decode/vd.c @@ -162,8 +162,7 @@ int mpcodecs_reconfig_vo(sh_video_t *sh, const struct mp_image_params *params) // Make sure the user-overrides are consistent (no RGB csp for YUV, etc.). mp_image_params_guess_csp(&p); - vocfg_flags = (opts->fullscreen ? VOFLAG_FULLSCREEN : 0) | - (flip ? VOFLAG_FLIPPING : 0); + vocfg_flags = (flip ? VOFLAG_FLIPPING : 0); // Time to config libvo! mp_msg(MSGT_CPLAYER, MSGL_V, -- cgit v1.2.3