From 11c044aa48e4dc14c86cdf37591115a2590e48f8 Mon Sep 17 00:00:00 2001 From: Ben Boeckel Date: Mon, 15 Sep 2014 20:50:43 -0400 Subject: TOOLS: shellcheck: quote variable expansions --- version.sh | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'version.sh') diff --git a/version.sh b/version.sh index 37802c6571..3eac7ef050 100755 --- a/version.sh +++ b/version.sh @@ -21,18 +21,18 @@ done # Extract revision number from file used by daily tarball snapshots # or from "git describe" output git_revision=$(cat snapshot_version 2> /dev/null) -test $git_revision || test ! -e .git || git_revision=$(git rev-parse --short HEAD) -test $git_revision && git_revision=git-$git_revision +test "$git_revision" || test ! -e .git || git_revision="$(git rev-parse --short HEAD)" +test "$git_revision" && git_revision="git-$git_revision" version="$git_revision" # releases extract the version number from the VERSION file -releaseversion=$(cat VERSION 2> /dev/null) -if test $releaseversion ; then - test $version && version="-$version" +releaseversion="$(cat VERSION 2> /dev/null)" +if test "$releaseversion" ; then + test "$version" && version="-$version" version="$releaseversion$version" fi -test $version || version=UNKNOWN +test "$version" || version=UNKNOWN VERSION="${version}${extra}" -- cgit v1.2.3