From e7db4ccf1afbb6653ae1aae44b1c96c724361985 Mon Sep 17 00:00:00 2001 From: rathann Date: Thu, 9 Feb 2006 14:08:03 +0000 Subject: Patch by Stefan Huehner / stefan % huehner ! org \ MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit patch replaces '()' for the correct '(void)' in function declarations/prototypes which have no parameters. The '()' syntax tell thats there is a variable list of arguments, so that the compiler cannot check this. The extra CFLAG '-Wstrict-declarations' shows those cases. Comments about a similar patch applied to ffmpeg: That in C++ these mean the same, but in ANSI C the semantics are different; function() is an (obsolete) K&R C style forward declaration, it basically means that the function can have any number and any types of parameters, effectively completely preventing the compiler from doing any sort of type checking. -- Erik Slagter Defining functions with unspecified arguments is allowed but bad. With arguments unspecified the compiler can't report an error/warning if the function is called with incorrect arguments. -- Måns Rullgård git-svn-id: svn://svn.mplayerhq.hu/mplayer/trunk@17567 b3059339-0415-0410-9bf9-f77b7e298cf2 --- sub_cc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'sub_cc.c') diff --git a/sub_cc.c b/sub_cc.c index 9f263aba66..422d045ef8 100644 --- a/sub_cc.c +++ b/sub_cc.c @@ -67,7 +67,7 @@ static void clear_buffer(subtitle *buf) } -void subcc_init() +void subcc_init(void) { int i; //printf("subcc_init(): initing...\n"); @@ -107,7 +107,7 @@ static void append_char(char c) } -static void swap_buffers() +static void swap_buffers(void) { subtitle *foo; foo=fb; @@ -185,7 +185,7 @@ static void cc_decode_EIA608(unsigned short int data) lastcode=data; } -static void subcc_decode() +static void subcc_decode(void) { /* The first number may denote a channel number. I don't have the * EIA-708 standard, so it is hard to say. -- cgit v1.2.3