From f3871193fcfc5feaee42c883496fa5f8f99eb4f5 Mon Sep 17 00:00:00 2001 From: wm4 Date: Mon, 3 Jun 2013 23:00:39 +0200 Subject: sd_srt, sd_microdvd: set ASS script resolution Both converters can output \pos and deal with font sizes, so they assume a specific script resolution (PlayResX/PlayResY). The implicit assumption was that a specific resolution was guaranteed. The MP_ASS_FONT_PLAYRESY constant is connected to this. Better make it explicit, so that the implicit dependency on MP_ASS_FONT_PLAYRESY is removed. (Unfortunately, libavcodec sub converters still don't set PlayResX/PlayResY explicitly, so the value set by that constant can't be declared as arbitrary yet.) PlayResY=288 is most likely the SSA natural script resolution (or something like this?), as well as the libass and VSFilter default. PlayResX=384 is the fallback value set by libass if PlayResY is set to 288, and PlayResX is unset. --- sub/ass_mp.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'sub/ass_mp.h') diff --git a/sub/ass_mp.h b/sub/ass_mp.h index b6ec2808c0..9f40b34166 100644 --- a/sub/ass_mp.h +++ b/sub/ass_mp.h @@ -27,7 +27,8 @@ #include "config.h" #include "subreader.h" -// font sizes and explicit tags in subassconvert.c assume this size (?) +// This is probably arbitrary. +// sd_lavc_conv might indirectly still assume this PlayResY, though. #define MP_ASS_FONT_PLAYRESY 288 #define MP_ASS_RGBA(r, g, b, a) \ -- cgit v1.2.3