From 95cfe58e3db9d939abe7a9a26116c1d576eed60b Mon Sep 17 00:00:00 2001 From: wm4 Date: Sat, 30 Nov 2013 22:40:51 +0100 Subject: Use O_CLOEXEC when creating FDs This is needed so that new processes (created with fork+exec) don't inherit open files, which can be important for a number of reasons. Since O_CLOEXEC is relatively new (POSIX.1-2008, before that Linux specific), we #define it to 0 in io.h to prevent compilation errors on older/crappy systems. At least this is the plan. input.c creates a pipe. For that, add a mp_set_cloexec() function (which is based on Weston's code in vo_wayland.c, but more correct). We could use pipe2() instead, but that is Linux specific. Technically, we have a race condition, but it won't matter. --- stream/stream_dvd_common.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'stream/stream_dvd_common.c') diff --git a/stream/stream_dvd_common.c b/stream/stream_dvd_common.c index 3416eea094..b079f97d06 100644 --- a/stream/stream_dvd_common.c +++ b/stream/stream_dvd_common.c @@ -39,6 +39,8 @@ #include #endif +#include "osdep/io.h" + #include "mpvcore/mp_msg.h" #include "stream_dvd_common.h" @@ -104,7 +106,7 @@ void dvd_set_speed(char *device, unsigned speed) AV_WB16(buffer + 18, 1000); AV_WB16(buffer + 26, 1000); - fd = open(device, O_RDWR | O_NONBLOCK); + fd = open(device, O_RDWR | O_NONBLOCK | O_CLOEXEC); if (fd == -1) { mp_tmsg(MSGT_OPEN, MSGL_INFO, "Couldn't open DVD device for writing, changing DVD speed needs write access.\n"); return; -- cgit v1.2.3