From f0feea55918e133ba3e6871e2bb1cbd9610cb2d1 Mon Sep 17 00:00:00 2001 From: wm4 Date: Fri, 13 Nov 2015 22:41:41 +0100 Subject: command: rename vo-missed-frame-count property "Missed" implies the frame was dropped, but what really happens is that the following frame will be shown later than intended (due to the current frame skipping a vsync). (As of this commit, this property is still inactive and always returns 0. See git blame for details.) --- player/command.c | 10 +++++----- player/osd.c | 10 ++-------- 2 files changed, 7 insertions(+), 13 deletions(-) (limited to 'player') diff --git a/player/command.c b/player/command.c index 6473de4af9..db368df079 100644 --- a/player/command.c +++ b/player/command.c @@ -583,14 +583,14 @@ static int mp_property_vo_drop_frame_count(void *ctx, struct m_property *prop, return m_property_int_ro(action, arg, vo_get_drop_count(mpctx->video_out)); } -static int mp_property_vo_missed_frame_count(void *ctx, struct m_property *prop, - int action, void *arg) +static int mp_property_vo_delayed_frame_count(void *ctx, struct m_property *prop, + int action, void *arg) { MPContext *mpctx = ctx; if (!mpctx->d_video) return M_PROPERTY_UNAVAILABLE; - return m_property_int_ro(action, arg, vo_get_missed_count(mpctx->video_out)); + return m_property_int_ro(action, arg, vo_get_delayed_count(mpctx->video_out)); } /// Current position in percent (RW) @@ -3395,7 +3395,7 @@ static const struct m_property mp_properties[] = { {"drop-frame-count", mp_property_drop_frame_cnt}, {"mistimed-frame-count", mp_property_mistimed_frame_count}, {"vo-drop-frame-count", mp_property_vo_drop_frame_count}, - {"vo-missed-frame-count", mp_property_vo_missed_frame_count}, + {"vo-delayed-frame-count", mp_property_vo_delayed_frame_count}, {"percent-pos", mp_property_percent_pos}, {"time-start", mp_property_time_start}, {"time-pos", mp_property_time_pos}, @@ -3612,7 +3612,7 @@ static const char *const *const mp_event_property_change[] = { "percent-pos", "time-remaining", "playtime-remaining", "playback-time", "estimated-vf-fps", "drop-frame-count", "vo-drop-frame-count", "total-avsync-change", "audio-speed-correction", "video-speed-correction", - "vo-missed-frame-count", "mistimed-frame-count"), + "vo-delayed-frame-count", "mistimed-frame-count"), E(MPV_EVENT_VIDEO_RECONFIG, "video-out-params", "video-params", "video-format", "video-codec", "video-bitrate", "dwidth", "dheight", "width", "height", "fps", "aspect", "vo-configured", "current-vo", diff --git a/player/osd.c b/player/osd.c index da14f8ff2b..596386ebae 100644 --- a/player/osd.c +++ b/player/osd.c @@ -234,14 +234,8 @@ static void print_status(struct MPContext *mpctx) // VO stats if (mpctx->d_video) { if (mpctx->display_sync_active) { - char *f = - mp_property_expand_string(mpctx, "${audio-speed-correction}"); - if (f) - saddf(&line, " DS: %s", f); - talloc_free(f); - int64_t m = vo_get_missed_count(mpctx->video_out); - if (m > 0) - saddf(&line, " Missed: %"PRId64, m); + saddf(&line, " DS: %d/%"PRId64, mpctx->mistimed_frames_total, + vo_get_delayed_count(mpctx->video_out)); } int64_t c = vo_get_drop_count(mpctx->video_out); if (c > 0 || mpctx->dropped_frames_total > 0) { -- cgit v1.2.3